You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
TYP: invalid default value documented on array's ndmax parameter #30159
first of: we also have a couple inspect-based tests in astropy intended to catch discrepancies between numpy signatures and our NEP 18 dispatch functions. Functions which didn't have signatures available at runtime were simply ignored, but your recent work has allowed finding many more issues with our NEP 18 implementations, so thanks a lot for that !
I'm seeing a small issue with gh-30138 though; None doesn't appear to be a valid value for array's ndmax argument at runtime (an integer is expected). Instead, and based on my understanding of gh-29569, it seems the default value should actually be 0.
It can be worked around in astropy alright, but it feels slightly off that I need to both re-expose the default value as None (granted, this part is imposed by our tests) and include logic in the implementation to handle this special case. It's also a bit awkward that the parameter is typed as int but uses None as a default.
changed the title [-]TYP: <Please write a comprehensive title after the 'TYP: ' prefix>[/-][+]TYP: invalid default value documented on `array`'s `ndmax` parameter[/+]on Nov 6, 2025
Activity
[-]TYP: <Please write a comprehensive title after the 'TYP: ' prefix>[/-][+]TYP: invalid default value documented on `array`'s `ndmax` parameter[/+]