Skip to content

BLD: many warnings around _LIBCPP_ENABLE_ASSERT on macos #29454

Closed

Description

@mattip

Meson is setting -D_LIBCPP_ENABLE_ASSERT on macos, but that has been deprecated and its use emits a warning when compiling. Upstream meson fixed the warning in mesonbuild/meson#14548. Are we due for a round of updating the vendored meson code soon or should we merge that change without updating the rest?

Activity

  1. rgommers commented on Jul 29, 2025

    @rgommers
    Member

    I'm fine with backporting that change separately, because I don't have much time to work through a larger update this week. I can always make time if it's urgent of course, but this doesn't feel all that urgent right now.

  2. mattip commented on Jul 29, 2025

    @mattip
    MemberAuthor

    Is there a rough guide to the vendored meson update process? Maybe others could help so the burden is not all on you

  3. rgommers commented on Jul 30, 2025

    @rgommers
    Member

    It's about resolving potentially tricky merge conflicts, so the first approach may not work. But ideally the process is to:

    1. Merge a new upstream release tag or recent commit on master into the main-numpymeson branch of our fork,
    2. Test that that works with all CI on this repo, by opening a PR or testing on your own fork
    3. Then review the diff on the merge (e.g., see Update to v1.6.1 meson#18 (review) for last time) and merge the PR on numpy/meson.
    4. Then bump the submodule version in this repo.
  4. mattip commented on Aug 1, 2025

    @mattip
    MemberAuthor

    Closing, an update of meson is preferable to a single PR backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions