Skip to content

Remove duplicate wishlist tab#2

Closed
star1327p wants to merge 2 commits intonumpy:mainfrom
star1327p:rm-dup-wish-list
Closed

Remove duplicate wishlist tab#2
star1327p wants to merge 2 commits intonumpy:mainfrom
star1327p:rm-dup-wish-list

Conversation

@star1327p
Copy link

Remove duplicate wishlist tab in search.html

numpy-circleci-bot and others added 2 commits January 16, 2025 00:13
@mattip
Copy link
Member

mattip commented Jan 16, 2025

I don't know why it says I closed this branch, and why it says I force pushed here. Strange.

@star1327p
Copy link
Author

@mattip The website still shows the duplicate wishlist tabs. Please reopen this PR and remerge the changes.
https://numpy.org/neps/

@mattip
Copy link
Member

mattip commented Jan 17, 2025

I did not do anything here. It seems somehow the branch was deleted, but even though my name is on the commit i did not touch it and the commits are no longer available. Should we try and report this to github? Please recreate the PR again, be sure to create a branch off main before committing your changes. Working on the main branch can be confusing.

@melissawm
Copy link
Member

I believe this is because this repo only has the artifacts for the neps, and maybe a new deployment trigger overwrote the PR branch from the source repo.

@star1327p any changes should be done to the sources at https://github.com/numpy/numpy/tree/main/doc/neps

Cheers!

@star1327p
Copy link
Author

@melissawm Thank you for explaining this! I have raised the PR in the correct numpy repo.
numpy/numpy#28179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants