Repository navigation
PR: Add CYTHON environment variable to mesonbuild.envconfig.ENV_VAR_COMPILER_MAP attribute. - #13
Closed
thomasmansencal wants to merge 1 commit into
Closed
thomasmansencal wants to merge 1 commit into
thomasmansencal wants to merge 1 commit into
Conversation
…MPILER_MAP` attribute.
Member
|
Thanks @kelsolaar. I see this was already done upstream: mesonbuild#12674. So I may take your PR as a ping to update to latest Meson in this repo, rather than only incorporate this fix. |
Author
|
Sounds good with me! |
Author
|
BTW, is there a reason for maintaining a fork and not pushing your changes to the main repo? |
Member
|
We have extensions for BLAS and SIMD detection that still need to be upstreamed. Once that's done we can drop our vendored copy. |
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
May 16, 2024
Member
|
This can be closed, right? |
Member
|
Yep, all good now. Thanks @kelsolaar and @mattip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The
CYTHONkey is required for custom build pipelines defining the build environment with variables.Cheers,
Thomas