Repository navigation
Fix #1995: right shift should be logical when first operand is unsigned - #2072
Merged
Merged
Conversation
Current coverage is 87.08% (diff: 100%)@@ master #2072 diff @@
==========================================
Files 305 305
Lines 55562 55565 +3
Methods 0 0
Messages 0 0
Branches 5752 5756 +4
==========================================
+ Hits 48384 48387 +3
Misses 6242 6242
Partials 936 936
|
Member
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the rules for bitshift operations: only the first operand matters for signedness, so that e.g.
unsigned >> 2will be considered unsigned and not signed.Note that Numpy is much more annoying: