Skip to content

test#2

Open
ntBre wants to merge 10 commits intomasterfrom
brent/github-ty
Open

test#2
ntBre wants to merge 10 commits intomasterfrom
brent/github-ty

Conversation

@ntBre
Copy link
Owner

@ntBre ntBre commented Feb 20, 2026

No description provided.

Comment on lines +14 to +17
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very secure, love it

Co-authored-by: Alex Waygood <[email protected]>
@ntBre ntBre added the ci label Feb 20, 2026
@ntBre ntBre closed this Feb 20, 2026
@ntBre ntBre reopened this Feb 20, 2026
ntBre added a commit to astral-sh/ruff that referenced this pull request Feb 23, 2026
## Summary

This PR updates our GitHub output format rendering to include
sub-diagnostics and secondary annotations rather than just the concise
message. As shown in the test plan, @AlexWaygood and I did some trial
and error to figure out how to get these to render correctly, with some
help from William on Discord too.

## Test Plan

Existing snapshot tests, updated to include a diagnostic with
sub-diagnostics (also reflected in some other unmodified output
formats), as well as manual testing in
ntBre/github-diagnostic-test#2:

<img width="825" height="302" alt="image"
src="https://github.com/user-attachments/assets/863f43ad-96d3-49c2-8af4-4cb2e32a950a"
/>

<img width="734" height="394" alt="image"
src="https://github.com/user-attachments/assets/3b793b73-b9f5-4493-b49a-b9af96f5116c"
/>

---------

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants