Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0#710
Update target frameworks for .NET 6, .NET Framework 4.6.2, .NET Standard 2.0#710alexandrnikitin merged 10 commits intonsubstitute:mainfrom Romfos:main
Conversation
|
Maybe someone can assis with build.fsx ? |
|
looks like fake-cli do not work as expected with dotnet 7+ |
There was a problem hiding this comment.
@Romfos Thank you for the PR.
Re versions: Keeping them as they were is the safe option. -* includes beta versions and looks too permissive for me, docs. IMO MAJOR.* is a better choice but I'm fine with either.
Re: build issue. I also get that error in my local environment. Not sure what's wrong with it.
There is an issue on FAKE repo fsprojects/FAKE#2722
I tried workarounds from there but no luck.
The last successful build on appveyor used FAKE 5.23.1 and .NET 6.0.400. Tried these versions in my local env but it fails too.
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3' or '$(TargetIsNetFx)' == 'true'"> | ||
| <PackageReference Include="Castle.Core" Version="4.4.1-*" /> | ||
| <ItemGroup> | ||
| <PackageReference Include="Castle.Core" Version="5.1.1" /> |
There was a problem hiding this comment.
I would keep the PackageReference version ranges as they were. It was 5.0.0-* for Castle.Core.
There was a problem hiding this comment.
I restored 5.0.0-*, but what is wrong with it? why do not use patched versions?
There was a problem hiding this comment.
Thank you! My point is to use floating/ range versions vs direct versions (5.1.1).
As for 5.0.0-* vs 5.1.1-*, dependencies are "flattened" and can be managed and upgraded by Application/NuGet directly. AFAIK NSubstitute works well with 5.0.0. I'm not aware of a strong reason to limit the lower boundary. Maybe I'm missing something.
In general, the floating to direct version change and mismatch of direct versions can potentially break an application.
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetIsNet5OrNewer)' == 'true'"> | ||
| <PackageReference Include="Castle.Core" Version="5.0.0-*" /> | ||
| <ItemGroup Condition="'$(TargetIsNet5OrNewer)' != 'true'"> | ||
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.3.0" /> |
There was a problem hiding this comment.
Same here, it was 4.3.0-*
|
pr was updated |
|
LGTM. It makes sense to align it with Castle.Core and remove out of support versions. Removing netstandard1.3 and net45 looks like a breaking change for me though. @dtchepak What do you think about the PR? Do we want to include anything else in the release? Any pending breaking changes? We probably want to sync it with nsubstitute/NSubstitute.Analyzers#198 cc @tpodolak |
I'm happy to release as-is. If you're happy could you please merge and I'll release? I still need to get to #700 (I want to do some more testing of that and update docs before releasing), but I can rebase that and put that in a later release. |
| @@ -1,3 +1,6 @@ | |||
| 4.5.0 Release | |||
There was a problem hiding this comment.
| 4.5.0 Release | |
| 5.0.0 Release |
| @@ -1,3 +1,6 @@ | |||
| ### 4.5.0 | |||
There was a problem hiding this comment.
| ### 4.5.0 | |
| ### 5.0.0 (Pending) |
|
All comments are fixed |
|
@Romfos Merged. Thank you for the PR! We appreciate it. |
I still need some time to do a proper testing of TargetFramework bump in analyzers, but IMO you dont need to wait for me as NSubstitute changes wont affect analyzers |
|
@alexandrnikitin Thanks for merging this. Happy for me to release this now? |
|
@dtchepak Yes, when you are ready. Thank you! |
|
Sorry for the delay. I've pushed 5.0.0 to nuget. Please give it a try and let me know ASAP if there are any problems. 🙇 Thanks very much for the contribution! |
4 participants
What's changed?
Why target frameworks were changed?
Microsoft recommend to target .NET 6, .NET Standard and minimal supported .NET Framework
https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/older-framework-versions-dropped
Castle.Core now have similar list of supported platforms
https://www.nuget.org/packages/castle.core/#dependencies-body-tab
Notes:
.NET Framework 4.6.1 is out of support, .NET Framework 4.6.2 is the older version that is still supported
https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/
.NET 5 is out of support
https://devblogs.microsoft.com/dotnet/dotnet-5-end-of-support-update/
.NET Core 3.1 is out of support
https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/