Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy #5

Copilot · 2025-09-16T14:16:16Z

Fixes CI workflows to only enforce branch, changelog, and milestone restrictions in the main astropy/astropy repository, allowing forks to open PRs against any branch without CI restrictions.

Problem

The current CI checks in .github/workflows/ci_workflows.yml, .github/workflows/check_changelog.yml, and .github/workflows/check_milestone.yml apply to all repositories, including forks. This means that users working in their own forks cannot open PRs against development branches or feature branches - they are forced to only target the main branch and must include changelog entries and milestones, which limits development workflow flexibility in forks.

Solution

Modified the base branch check, towncrier changelog check, and milestone check to only apply when the repository is the main astropy/astropy repository using the simple if: github.repository == 'astropy/astropy' condition.

For the main repository (astropy/astropy):

PRs are still restricted to the main branch (unless using skip label or meeseeks auto-backport)
Changelog entries are still required via towncrier
Milestones are still required
All existing protection remains in place

For fork repositories (e.g., user/astropy):

PRs can be opened against any branch without restriction
Changelog validation is skipped
Milestone requirements are skipped
Enables flexible development workflows in forks

Changes

Base Branch Check (ci_workflows.yml):

Added github.repository == 'astropy/astropy' condition to the existing check
Preserved all existing functionality and edge cases (skip labels, meeseeks, etc.)

Towncrier Changelog Check (check_changelog.yml):

Added if: github.repository == 'astropy/astropy' condition to the towncrier action
Simple and clean single-condition implementation

Milestone Check (check_milestone.yml):

Uses the existing simple if: github.repository == 'astropy/astropy' condition
Clean and straightforward implementation

The changes are minimal and maintain backward compatibility while enabling the desired fork flexibility for branch targeting, changelog requirements, and milestone requirements. All implementations use the simple and clean if: github.repository == 'astropy/astropy' pattern.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Cannot use the version setter because we allow v1.0 files to be read from XML even though we don't allow someone to create one with the APIs directly.

This ensures that error messages can report the actual version without having to work it out from the or_later values.

…ng a `PyObject*` type

Fix bug in Wcs.wcs.print_contents() related to stdout buffer not bein…

…eels

FIX: Issue 15397

Fix _naxis dimensionality

…th more than 2 dimensions but with _naxis not set would fail, and that slicing a WCS with an ellipsis would not return a WCS object but a SlicedFITSWCS instead

github-actions · 2025-09-16T14:17:13Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2025-09-16T14:17:15Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

nstarman · 2025-09-16T14:18:38Z

@copilot also update the towncrier CI check to only apply to PRs on the astropy repo.

Co-authored-by: nstarman <[email protected]>

…tory Co-authored-by: nstarman <[email protected]>

Copilot · 2025-09-16T14:22:44Z

@copilot also update the towncrier CI check to only apply to PRs on the astropy repo.

Updated the towncrier changelog check in .github/workflows/check_changelog.yml to only apply to PRs in the main astropy/astropy repository. Fork repositories will now skip both the base branch check and changelog validation. Changes committed in f76aed7.

nstarman · 2025-09-16T14:24:47Z

@copilot also update the milestone check to only apply to PRs on the astropy repo, not forks.

Co-authored-by: nstarman <[email protected]>

nstarman · 2025-09-16T15:41:38Z

@copilot does if: github.repository == 'astropy/astropy' not work? If it does, then use that instead of more complex solutions.

…ub scripts Co-authored-by: nstarman <[email protected]>

Copilot · 2025-09-16T15:44:09Z

@copilot does if: github.repository == 'astropy/astropy' not work? If it does, then use that instead of more complex solutions.

You're absolutely right! The simple if: github.repository == 'astropy/astropy' condition works perfectly and is much cleaner. I've simplified all three workflows to use this approach instead of the complex GitHub script solutions. Changes committed in 0ad1a91.

Allow controlling warnings when converting deprecated units to strings

…3220

timj and others added 30 commits July 11, 2025 12:46

Add test for BINARY2 being allowed

643c2e0

Say that BINARY2 is allowed now in warning message

1809a61

Add VOTableFile.config property and ensure it always has version params

3d6e9e9

Fix version look up in error message.

fb1c73d

Add tests for version differences in CooSys and TimeSys

44eac5f

Reduce duplication of version check logic in VOTableFile

0f8e148

Force update of version of VOTableFile during parse

e66fb62

Cannot use the version setter because we allow v1.0 files to be read from XML even though we don't allow someone to create one with the APIs directly.

Add a test for Param field to check warning path

4cb684b

Reformat with ruff

f7bf1ed

Ruff format

f18307f

Store the VOTable version in the version check config

32b8861

This ensures that error messages can report the actual version without having to work it out from the or_later values.

Add news fragments

0858cf4

WHL: build and distribute stable-ABI-compliant wheels

5edb080

BLD: fix missing explicit pointer type casting in C functions expecti…

bc5b9e9

…ng a `PyObject*` type

Merge pull request astropy#18350 from astrofrog/wcs-flush-stdout

530f3b4

Fix bug in Wcs.wcs.print_contents() related to stdout buffer not bein…

Merge pull request astropy#18420 from neutrinoceros/whl/build-abi3-wh…

d02ffa9

…eels

Added tests for np.min,np.max,np.mean, and np.sum for ndarithmetic

95d9d9e

Fixed tests for ndarithmetic

34b27b4

Fixed problems with unsupported numpy keys for certain numpy functions

76bfb2a

Adding changelog docs

7e5fe8c

Added tests for ValueError exceptions with keys

127e05c

Merge pull request astropy#18424 from Nanoemc/issue_15397

96b8daf

FIX: Issue 15397

Fix _naxis dimensionality

22f7c28

Remove @astrofrog code

9208f89

Add change log entry

254efa4

fix eol

427d381

Merge pull request astropy#18419 from mcara/fix_naxis

bf90d9b

Fix _naxis dimensionality

Fixed bugs with WCS slicing, specifically that slicing WCS objects wi…

f0a59f4

…th more than 2 dimensions but with _naxis not set would fail, and that slicing a WCS with an ellipsis would not return a WCS object but a SlicedFITSWCS instead

Fix codestyle

f4541b0

Initial plan

ab616b8

Copilot AI assigned Copilot and nstarman Sep 16, 2025

Copilot started work on behalf of nstarman September 16, 2025 14:16 View session

nstarman added this to the v7.2.0 milestone Sep 16, 2025

Fix base branch check to only apply to main astropy repository

24aeb73

Co-authored-by: nstarman <[email protected]>

Copilot finished work on behalf of nstarman September 16, 2025 14:20

Copilot AI requested a review from nstarman September 16, 2025 14:20

Copilot started work on behalf of nstarman September 16, 2025 14:20 View session

Update towncrier changelog check to only apply to main astropy reposi…

f76aed7

…tory Co-authored-by: nstarman <[email protected]>

Copilot AI changed the title ~~Allow PRs against any branch in forks while restricting to main in astropy/astropy~~ Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy Sep 16, 2025

Copilot finished work on behalf of nstarman September 16, 2025 14:23

Copilot started work on behalf of nstarman September 16, 2025 14:24 View session

nstarman removed this from the v7.2.0 milestone Sep 16, 2025

Update milestone check to only apply to main astropy repository

fd918a4

Co-authored-by: nstarman <[email protected]>

Copilot finished work on behalf of nstarman September 16, 2025 14:29

Copilot started work on behalf of nstarman September 16, 2025 15:41 View session

Simplify CI checks to use simple if condition instead of complex GitH…

0ad1a91

…ub scripts Co-authored-by: nstarman <[email protected]>

Copilot stopped work on behalf of nstarman due to an error September 16, 2025 15:45
Copilot has encountered an error. See logs for additional details.

mhvk and others added 2 commits September 16, 2025 12:34

Merge pull request astropy#18586 from eerovaher/writing-deprecated-units

21b319f

Allow controlling warnings when converting deprecated units to strings

Merge branch 'main' into copilot/fix-a8e9ea88-fe35-4c07-9ba0-07a09052…

c292438

…3220

nstarman closed this Sep 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy #5

Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy #5

Uh oh!

Copilot AI commented Sep 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

Copilot AI commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

Copilot AI commented Sep 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy #5

Allow PRs against any branch in forks while restricting CI checks to main in astropy/astropy #5

Uh oh!

Conversation

Copilot AI commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Changes

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

Copilot AI commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

nstarman commented Sep 16, 2025

Uh oh!

Copilot AI commented Sep 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Copilot AI commented Sep 16, 2025 •

edited

Loading