Skip to content

Find the bug part 2 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nshalman wants to merge 7 commits into from
Closed

Find the bug part 2 #1

nshalman wants to merge 7 commits into from

Conversation

@nshalman
Copy link
Owner

@nshalman nshalman commented Jun 2, 2021

Given that nshalman/sys@master...nshalman:fsnotify-fen passes the tests I've written so far, when compiling against that source tree, many tests pass, but sadly not all of them.
The current mystery is why...

$ git checkout rebased-solaris-fen ; go test
Switched to branch 'rebased-solaris-fen'
PASS
ok      github.com/fsnotify/fsnotify    7.965s

$ git checkout illumos-fen ; go test
Switched to branch 'illumos-fen'
--- FAIL: TestFsnotifyMultipleOperations (0.66s)
    integration_test.go:104: event received: "/tmp/fsnotify549331660": WRITE
    integration_test.go:104: event received: "/tmp/fsnotify549331660": WRITE
    integration_test.go:104: event received: "/tmp/fsnotify549331660": WRITE
    integration_test.go:167: incorrect number of create events received after 500 ms (0 vs 2)
    integration_test.go:104: event received: "/tmp/fsnotify549331660": REMOVE
--- FAIL: TestFsnotifyMultipleCreates (0.76s)
    integration_test.go:217: event received: "/tmp/fsnotify105877982": WRITE
    integration_test.go:217: event received: "/tmp/fsnotify105877982": WRITE
    integration_test.go:217: event received: "/tmp/fsnotify105877982": WRITE
    integration_test.go:294: incorrect number of create events received after 500 ms (0 vs 2)
    integration_test.go:217: event received: "/tmp/fsnotify105877982": REMOVE
--- FAIL: TestFsnotifyDirOnly (0.55s)
    integration_test.go:356: event received: "/tmp/fsnotify542869925": WRITE
    integration_test.go:356: event received: "/tmp/fsnotify542869925": WRITE
    integration_test.go:356: event received: "/tmp/fsnotify542869925/TestFsnotifyEventsExisting.testfile": REMOVE
    integration_test.go:396: incorrect number of create events received after 500 ms (0 vs 1)
--- FAIL: TestFsnotifySubDir (0.70s)
    integration_test.go:504: event received: "/tmp/fsnotify719264031": WRITE
    integration_test.go:504: event received: "/tmp/fsnotify719264031": WRITE
    integration_test.go:553: incorrect number of create events received after 500 ms (0 vs 2)
--- FAIL: TestFsnotifyRenameToCreate (0.51s)
    integration_test.go:684: event received: "/tmp/fsnotify559598761": WRITE
    integration_test.go:709: fsnotify create events have not been received after 500 ms
    integration_test.go:684: event received: "/tmp/fsnotify559598761": REMOVE
--- FAIL: TestFsnotifyFakeSymlink (0.50s)
    integration_test.go:1053: Created bogus symlink
    integration_test.go:1039: event received: "/tmp/fsnotify564860890": WRITE
    integration_test.go:1063: fsnotify other events received on the broken link
    integration_test.go:1039: event received: "/tmp/fsnotify564860890": REMOVE
--- FAIL: TestCyclicSymlink (0.50s)
    integration_test.go:1120: want at least 1 create event got 0
FAIL
exit status 1
FAIL    github.com/fsnotify/fsnotify    7.971s

@nshalman nshalman mentioned this pull request Jun 2, 2021
Closed
@nshalman
Copy link
Owner Author

nshalman commented Jun 3, 2021

Fixed!

@nshalman nshalman closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshalman