conversion to and from scala std duration #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- provides a solution for #71 based on milliseconds - since 2.9.1 and 2.9.2 do not contain the std duration implementation, these would need to be dropped (is it still necessary to support these?) - renames DateImplicits to ConversionImplicits
Member
|
Thanks for sending PR. Would you tell us more detail why DateImplicits need to rename? regards, |
Member
|
We can accept that Scala 2.9.1 and 2.9.2 support is dropped. |
Contributor
Author
|
I thought about renaming because the new name fits better, but I revert. |
Member
|
awesome! I agree that ConversionImplicits is natural name. |
Member
|
Cool, LGTM. |
Member
|
👍 |
xuwei-k
added a commit
that referenced
this pull request
Sep 26, 2014
conversion to and from scala std duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these would need to be dropped (is it still necessary to support
these?)