fix(js): use explicit nx/bin/nx path in start-local-registry#35127
Merged
Conversation
## Current Behavior
`start-local-registry.ts` uses `require.resolve('nx')` to find the nx
CLI binary for forking a child process. This resolves the package's
`main` entry point, which only incidentally points to the binary.
In pnpm strict mode, this resolution fails when called from within
`@nx/js` because `@nx/js` doesn't declare `nx` as a direct dependency.
## Expected Behavior
Use `require.resolve('nx/bin/nx')` to explicitly resolve the CLI binary
entry point. This is semantically correct (the intent is to fork the nx
CLI) and doesn't rely on the `main` field or pnpm hoisting behavior.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 4f51808
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Apr 1, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 1, 2026
## Current Behavior
`start-local-registry.ts` uses `require.resolve('nx')` to find the nx
CLI binary for forking a child process. This resolves the package's
`main` entry point, which only incidentally points to the binary. In
pnpm strict mode, this resolution fails when called from within `@nx/js`
because `@nx/js` doesn't declare `nx` as a direct dependency.
## Expected Behavior
Use `require.resolve('nx/bin/nx')` to explicitly resolve the CLI binary
entry point. This is semantically correct (the intent is to fork the nx
CLI) and doesn't rely on the `main` field or pnpm hoisting behavior.
(cherry picked from commit 49a0e3f)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
start-local-registry.tsusesrequire.resolve('nx')to find the nx CLI binary for forking a child process. This resolves the package'smainentry point, which only incidentally points to the binary. In pnpm strict mode, this resolution fails when called from within@nx/jsbecause@nx/jsdoesn't declarenxas a direct dependency.Expected Behavior
Use
require.resolve('nx/bin/nx')to explicitly resolve the CLI binary entry point. This is semantically correct (the intent is to fork the nx CLI) and doesn't rely on themainfield or pnpm hoisting behavior.