fix(repo): re-enable Cypress HMR e2e tests after upstream tapable fix#35105
Merged
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit e7cfd49
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The upstream webpack/tapable issue (webpack/webpack#20693) has been resolved. Re-enable the 6 e2e tests that were skipped in #34969.
FrozenPandaz
force-pushed
the
fix/reenable-cypress-hmr-tests
branch
from
be01441 to
e7cfd49
Compare
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We identified that the failing task e2e-react:e2e-ci--src/react-router-ts-solution.test.ts is unrelated to the changes in this PR, which only re-enable previously skipped Cypress HMR tests. The error — a TypeScript type incompatibility between [email protected] and [email protected] in a generated test workspace — has been confirmed to exist on master as well, indicating a pre-existing environment issue.
No code changes were suggested for this issue.
Trigger a rerun:
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
AgentEnder
approved these changes
Mar 31, 2026
FrozenPandaz
added a commit
that referenced
this pull request
Mar 31, 2026
…#35105) ## Current Behavior Six e2e tests were skipped in #34969 because they were failing with a Cypress uncaught exception: `[HMR] Hot Module Replacement is disabled`. The error originated from the webpack `styles.js` bundle during the `before each` hook due to an upstream tapable issue (webpack/webpack#20693). Skipped tests: - `e2e-nx:e2e-ci--src/workspace-legacy.test.ts` - `e2e-react:e2e-ci--src/module-federation/independent-deployability.webpack.test.ts` - `e2e-react:e2e-ci--src/module-federation/core-webpack-basic-host-remote-generation.test.ts` - `e2e-react:e2e-ci--src/module-federation/misc-rspack-interoperability.test.ts` - `e2e-react:e2e-ci--src/module-federation/dynamic-federation.webpack.test.ts` - `e2e-react:e2e-ci--src/module-federation/federate-module.webpack.test.ts` ## Expected Behavior The upstream tapable issue has been resolved (webpack/webpack#20693). All 6 tests should be re-enabled and passing. ## Related Issue(s) Upstream fix: webpack/webpack#20693 Reverts the skip from #34969
vsavkin
pushed a commit
that referenced
this pull request
Apr 1, 2026
…#35105) ## Current Behavior Six e2e tests were skipped in #34969 because they were failing with a Cypress uncaught exception: `[HMR] Hot Module Replacement is disabled`. The error originated from the webpack `styles.js` bundle during the `before each` hook due to an upstream tapable issue (webpack/webpack#20693). Skipped tests: - `e2e-nx:e2e-ci--src/workspace-legacy.test.ts` - `e2e-react:e2e-ci--src/module-federation/independent-deployability.webpack.test.ts` - `e2e-react:e2e-ci--src/module-federation/core-webpack-basic-host-remote-generation.test.ts` - `e2e-react:e2e-ci--src/module-federation/misc-rspack-interoperability.test.ts` - `e2e-react:e2e-ci--src/module-federation/dynamic-federation.webpack.test.ts` - `e2e-react:e2e-ci--src/module-federation/federate-module.webpack.test.ts` ## Expected Behavior The upstream tapable issue has been resolved (webpack/webpack#20693). All 6 tests should be re-enabled and passing. ## Related Issue(s) Upstream fix: webpack/webpack#20693 Reverts the skip from #34969
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Six e2e tests were skipped in #34969 because they were failing with a Cypress uncaught exception:
[HMR] Hot Module Replacement is disabled. The error originated from the webpackstyles.jsbundle during thebefore eachhook due to an upstream tapable issue (webpack/webpack#20693).Skipped tests:
e2e-nx:e2e-ci--src/workspace-legacy.test.tse2e-react:e2e-ci--src/module-federation/independent-deployability.webpack.test.tse2e-react:e2e-ci--src/module-federation/core-webpack-basic-host-remote-generation.test.tse2e-react:e2e-ci--src/module-federation/misc-rspack-interoperability.test.tse2e-react:e2e-ci--src/module-federation/dynamic-federation.webpack.test.tse2e-react:e2e-ci--src/module-federation/federate-module.webpack.test.tsExpected Behavior
The upstream tapable issue has been resolved (webpack/webpack#20693). All 6 tests should be re-enabled and passing.
Related Issue(s)
Upstream fix: webpack/webpack#20693
Reverts the skip from #34969