fix(angular-rspack): use relative path for postcss-cli-resources output#34681
Merged
FrozenPandaz merged 1 commit intomasterfrom Mar 3, 2026
Merged
fix(angular-rspack): use relative path for postcss-cli-resources output#34681FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
The resourcesOutputPath passed to postcss-cli-resources was an absolute filesystem path, causing CSS url() values to contain absolute paths instead of relative ones.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 42d6edc
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Mar 3, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 4, 2026
…ut (#34681) ## Current Behavior When using `@nx/angular-rspack` with SCSS imports that reference external assets (e.g., `flag-icon-css`), the `postcss-cli-resources` plugin generates absolute filesystem paths in CSS `url()` values: ```css .flag-icon-us{background-image:url(/some/project/path/dist/bug-demo/browser/media/us.2d0a1dd6.svg)} ``` This happens because `normalizeOutputPath()` makes `outputPath.media` absolute, and this absolute path is passed directly as `resourcesOutputPath` to `postcss-cli-resources`. ## Expected Behavior CSS `url()` values contain relative paths: ```css .flag-icon-us{background-image:url(media/us.2d0a1dd6.svg)} ``` ## Related Issue(s) Fixes #34092 (cherry picked from commit 1a973ba)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using
@nx/angular-rspackwith SCSS imports that reference external assets (e.g.,flag-icon-css), thepostcss-cli-resourcesplugin generates absolute filesystem paths in CSSurl()values:This happens because
normalizeOutputPath()makesoutputPath.mediaabsolute, and this absolute path is passed directly asresourcesOutputPathtopostcss-cli-resources.Expected Behavior
CSS
url()values contain relative paths:Related Issue(s)
Fixes #34092