Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 80bc5ca
☁️ Nx Cloud last updated this comment at |
…es files ## Current Behavior 10 nx.dev URLs return 404 (e.g. /nx-api/nx/documents/release, /ci/features/polygraph, /code-owners). ~20 wildcard redirect rules silently broken because :slug* was never converted to Netlify's */splat syntax. Specific /getting-started/ rules ordered after the wildcard catch-all, sending users to the wrong page. ## Expected Behavior All documented nx.dev URLs resolve correctly. _redirects is the sole source of truth — no more JS generator pipeline. ## Related Issue(s) Fixes DOC-428
bcabanes
approved these changes
Mar 2, 2026
barbados-clemens
approved these changes
Mar 2, 2026
jaysoo
added a commit
that referenced
this pull request
Mar 3, 2026
…es files (#34673) ## Current Behavior 10 `nx.dev` URLs return 404 — broken links in CLI output, graph UI, and cloud UI. Additionally: - ~20 wildcard redirect rules silently broken because `:slug*` was never converted to Netlify's `*`/`:splat` syntax - Specific `/getting-started/` rules ordered after the wildcard catch-all, sending users to the generic intro page instead of the correct page (e.g., `/getting-started/editor-setup`) - Redirect chain breaks where intermediate targets (e.g., `/nx-api/powerpack-*-cache` → `/nx-api/*-cache`) had no rule ## Expected Behavior All documented `nx.dev` URLs resolve correctly. `_redirects` is the sole source of truth — no more JS generator pipeline. ### Changes 1. **Fixed `_redirects`**: - Converted all `:slug*` to `*`/`:splat` (Netlify syntax) - Reordered specific `/getting-started/` rules before the wildcard catch-all - Added 13 new redirect rules for broken 404 URLs 2. **Fixed `astro-docs/netlify.toml`**: - Added 3 redirects for `/docs/` path typos (trailing-s, wrong path) 3. **Deleted legacy files** (-2,248 lines): - `redirect-rules.js` - `redirect-rules-docs-to-astro.js` - `redirect-rules.spec.js` - `scripts/generate-netlify-redirects.mjs` ## Related Issue(s) Fixes DOC-428
jaysoo
added a commit
that referenced
this pull request
Mar 3, 2026
…es files (#34673) ## Current Behavior 10 `nx.dev` URLs return 404 — broken links in CLI output, graph UI, and cloud UI. Additionally: - ~20 wildcard redirect rules silently broken because `:slug*` was never converted to Netlify's `*`/`:splat` syntax - Specific `/getting-started/` rules ordered after the wildcard catch-all, sending users to the generic intro page instead of the correct page (e.g., `/getting-started/editor-setup`) - Redirect chain breaks where intermediate targets (e.g., `/nx-api/powerpack-*-cache` → `/nx-api/*-cache`) had no rule ## Expected Behavior All documented `nx.dev` URLs resolve correctly. `_redirects` is the sole source of truth — no more JS generator pipeline. ### Changes 1. **Fixed `_redirects`**: - Converted all `:slug*` to `*`/`:splat` (Netlify syntax) - Reordered specific `/getting-started/` rules before the wildcard catch-all - Added 13 new redirect rules for broken 404 URLs 2. **Fixed `astro-docs/netlify.toml`**: - Added 3 redirects for `/docs/` path typos (trailing-s, wrong path) 3. **Deleted legacy files** (-2,248 lines): - `redirect-rules.js` - `redirect-rules-docs-to-astro.js` - `redirect-rules.spec.js` - `scripts/generate-netlify-redirects.mjs` ## Related Issue(s) Fixes DOC-428
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 4, 2026
…es files (#34673) ## Current Behavior 10 `nx.dev` URLs return 404 — broken links in CLI output, graph UI, and cloud UI. Additionally: - ~20 wildcard redirect rules silently broken because `:slug*` was never converted to Netlify's `*`/`:splat` syntax - Specific `/getting-started/` rules ordered after the wildcard catch-all, sending users to the generic intro page instead of the correct page (e.g., `/getting-started/editor-setup`) - Redirect chain breaks where intermediate targets (e.g., `/nx-api/powerpack-*-cache` → `/nx-api/*-cache`) had no rule ## Expected Behavior All documented `nx.dev` URLs resolve correctly. `_redirects` is the sole source of truth — no more JS generator pipeline. ### Changes 1. **Fixed `_redirects`**: - Converted all `:slug*` to `*`/`:splat` (Netlify syntax) - Reordered specific `/getting-started/` rules before the wildcard catch-all - Added 13 new redirect rules for broken 404 URLs 2. **Fixed `astro-docs/netlify.toml`**: - Added 3 redirects for `/docs/` path typos (trailing-s, wrong path) 3. **Deleted legacy files** (-2,248 lines): - `redirect-rules.js` - `redirect-rules-docs-to-astro.js` - `redirect-rules.spec.js` - `scripts/generate-netlify-redirects.mjs` ## Related Issue(s) Fixes DOC-428 (cherry picked from commit f42be4e)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
10
nx.devURLs return 404 — broken links in CLI output, graph UI, and cloud UI. Additionally::slug*was never converted to Netlify's*/:splatsyntax/getting-started/rules ordered after the wildcard catch-all, sending users to the generic intro page instead of the correct page (e.g.,/getting-started/editor-setup)/nx-api/powerpack-*-cache→/nx-api/*-cache) had no ruleExpected Behavior
All documented
nx.devURLs resolve correctly._redirectsis the sole source of truth — no more JS generator pipeline.Changes
Fixed
_redirects::slug*to*/:splat(Netlify syntax)/getting-started/rules before the wildcard catch-allFixed
astro-docs/netlify.toml:/docs/path typos (trailing-s, wrong path)Deleted legacy files (-2,248 lines):
redirect-rules.jsredirect-rules-docs-to-astro.jsredirect-rules.spec.jsscripts/generate-netlify-redirects.mjsRelated Issue(s)
Fixes DOC-428