fix(core): remove unused getTerminalOutput from BatchProcess#34604
Merged
FrozenPandaz merged 2 commits intomasterfrom Feb 25, 2026
Merged
fix(core): remove unused getTerminalOutput from BatchProcess#34604FrozenPandaz merged 2 commits intomasterfrom
FrozenPandaz merged 2 commits intomasterfrom
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 8fb55d9
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
FrozenPandaz
approved these changes
Feb 25, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior `BatchProcess` accumulates all stdout/stderr output in `terminalOutputChunks` and exposes it via `getTerminalOutput()`, but nothing ever calls `getTerminalOutput()`. The accumulated strings are unique allocations (created via `chunk.toString()`), not shared with the output callbacks or `process.stdout.write`. For verbose batched tasks (e.g., Maven/Gradle with hundreds of tasks), this can hold tens to hundreds of MB for the entire batch duration. ## Expected Behavior Remove the dead accumulation code. stdout/stderr chunks are still forwarded to `process.stdout`/`process.stderr` and output callbacks as before — only the unused storage is removed. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> (cherry picked from commit 872b9c9)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior `BatchProcess` accumulates all stdout/stderr output in `terminalOutputChunks` and exposes it via `getTerminalOutput()`, but nothing ever calls `getTerminalOutput()`. The accumulated strings are unique allocations (created via `chunk.toString()`), not shared with the output callbacks or `process.stdout.write`. For verbose batched tasks (e.g., Maven/Gradle with hundreds of tasks), this can hold tens to hundreds of MB for the entire batch duration. ## Expected Behavior Remove the dead accumulation code. stdout/stderr chunks are still forwarded to `process.stdout`/`process.stderr` and output callbacks as before — only the unused storage is removed. --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> (cherry picked from commit 872b9c9)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
BatchProcessaccumulates all stdout/stderr output interminalOutputChunksand exposes it viagetTerminalOutput(), but nothing ever callsgetTerminalOutput(). The accumulated strings are unique allocations (created viachunk.toString()), not shared with the output callbacks orprocess.stdout.write.For verbose batched tasks (e.g., Maven/Gradle with hundreds of tasks), this can hold tens to hundreds of MB for the entire batch duration.
Expected Behavior
Remove the dead accumulation code. stdout/stderr chunks are still forwarded to
process.stdout/process.stderrand output callbacks as before — only the unused storage is removed.