fix(core): reject pending promises directly when plugin worker exits unexpectedly#34588
Merged
FrozenPandaz merged 1 commit intomasterfrom Feb 24, 2026
Merged
fix(core): reject pending promises directly when plugin worker exits unexpectedly#34588FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
…unexpectedly When a plugin worker process exits unexpectedly, the exit handler previously sent synthetic `loadResult` messages to all pending response handlers. If any handler was waiting for a different result type (e.g. `createNodesResult`), the type validation would reject with a confusing "Expected createNodesResult, got loadResult" error instead of surfacing the actual cause. Split response handlers into `onMessage` / `onError` callbacks so the exit handler can reject each pending promise directly with a clear "Plugin worker exited unexpectedly" error. Also use unique transaction IDs for `load` messages (via `generateTxId`) to avoid potential handler overwrites during worker restarts. Fixes #34564
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 60e1618
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FrozenPandaz
approved these changes
Feb 24, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…unexpectedly (#34588) When a plugin worker process exits unexpectedly, the exit handler previously sent synthetic `loadResult` messages to all pending response handlers. If any handler was waiting for a different result type (e.g. `createNodesResult`), the type validation would reject with a confusing "Expected createNodesResult, got loadResult" error instead of surfacing the actual cause. Split response handlers into `onMessage` / `onError` callbacks so the exit handler can reject each pending promise directly with a clear "Plugin worker exited unexpectedly" error. Also use unique transaction IDs for `load` messages (via `generateTxId`) to avoid potential handler overwrites during worker restarts. Fixes #34564 (cherry picked from commit 1ecf0fb)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…unexpectedly (#34588) When a plugin worker process exits unexpectedly, the exit handler previously sent synthetic `loadResult` messages to all pending response handlers. If any handler was waiting for a different result type (e.g. `createNodesResult`), the type validation would reject with a confusing "Expected createNodesResult, got loadResult" error instead of surfacing the actual cause. Split response handlers into `onMessage` / `onError` callbacks so the exit handler can reject each pending promise directly with a clear "Plugin worker exited unexpectedly" error. Also use unique transaction IDs for `load` messages (via `generateTxId`) to avoid potential handler overwrites during worker restarts. Fixes #34564 (cherry picked from commit 1ecf0fb)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin worker process exits unexpectedly, the exit handler previously sent synthetic
loadResultmessages to all pending response handlers. If any handler was waiting for a different result type (e.g.createNodesResult), the type validation would reject with a confusing "Expected createNodesResult, got loadResult" error instead of surfacing the actual cause.Split response handlers into
onMessage/onErrorcallbacks so the exit handler can reject each pending promise directly with a clear "Plugin worker exited unexpectedly" error.Also use unique transaction IDs for
loadmessages (viagenerateTxId) to avoid potential handler overwrites during worker restarts.Fixes #34564