fix(bundling): fix regression on process.env usage for webpack#34583
Merged
fix(bundling): fix regression on process.env usage for webpack#34583
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit 069753c
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
When we optimized the `process.env` values to not embed the full object unnecessarily, we also regressed in cases where users do use `process.env` instead of `process.env["NX_PUBLIC_FOO"]`. ## Current behavior Users cannot use `process.env` and must access each key individuall. Although the serializing the full object can bloat bundle sizes, we also don't want to break existing apps unnecessarily. ## Expected behavior Existing apps should continue to work as usual. ## Related issues Fixes #34279
Coly010
approved these changes
Feb 25, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
When we optimized the `process.env` values to not embed the full object unnecessarily, we also regressed in cases where users do use `process.env` instead of `process.env["NX_PUBLIC_FOO"]`. ## Current behavior Users cannot use `process.env` and must access each key individuall. Although the serializing the full object can bloat bundle sizes, we also don't want to break existing apps unnecessarily. ## Expected behavior Existing apps should continue to work as usual. ## Related issues Fixes #34279 (cherry picked from commit 127255a)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
When we optimized the `process.env` values to not embed the full object unnecessarily, we also regressed in cases where users do use `process.env` instead of `process.env["NX_PUBLIC_FOO"]`. ## Current behavior Users cannot use `process.env` and must access each key individuall. Although the serializing the full object can bloat bundle sizes, we also don't want to break existing apps unnecessarily. ## Expected behavior Existing apps should continue to work as usual. ## Related issues Fixes #34279 (cherry picked from commit 127255a)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we optimized the
process.envvalues to not embed the full objectunnecessarily, we also regressed in cases where users do use
process.envinstead ofprocess.env["NX_PUBLIC_FOO"].Current behavior
Users cannot use
process.envand must access each key individuall.Although the serializing the full object can bloat bundle sizes, we also
don't want to break existing apps unnecessarily.
Expected behavior
Existing apps should continue to work as usual.
Related issues
Fixes #34279