fix(js): use per-invocation cache in TS plugin to fix NX_ISOLATE_PLUGINS=false#34566
Merged
fix(js): use per-invocation cache in TS plugin to fix NX_ISOLATE_PLUGINS=false#34566
Conversation
…INS=false When plugin isolation is off, concurrent createNodesV2 invocations share the same module instance. The module-level mutable `cache` variable caused invocation A's `finally` block to null it out while invocation B was still reading from it, resulting in "Cannot read properties of null (reading 'configContexts')". Replace the shared mutable `cache` with a Symbol-keyed Map so each invocation gets its own isolated cache. The tsconfig disk cache is shared across invocations with an idempotent initialization guard.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 4341d21
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Feb 24, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…INS=false (#34566) When plugin isolation is off, concurrent createNodesV2 invocations share the same module instance. The module-level mutable `cache` variable caused invocation A's `finally` block to null it out while invocation B was still reading from it, resulting in "Cannot read properties of null (reading 'configContexts')". Replace the shared mutable `cache` with a Symbol-keyed Map so each invocation gets its own isolated cache. The tsconfig disk cache is shared across invocations with an idempotent initialization guard. CLOSES NXC-3971 (cherry picked from commit 1a15ea1)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…INS=false (#34566) When plugin isolation is off, concurrent createNodesV2 invocations share the same module instance. The module-level mutable `cache` variable caused invocation A's `finally` block to null it out while invocation B was still reading from it, resulting in "Cannot read properties of null (reading 'configContexts')". Replace the shared mutable `cache` with a Symbol-keyed Map so each invocation gets its own isolated cache. The tsconfig disk cache is shared across invocations with an idempotent initialization guard. CLOSES NXC-3971 (cherry picked from commit 1a15ea1)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When plugin isolation is off, concurrent createNodesV2 invocations share
the same module instance. The module-level mutable
cachevariable causedinvocation A's
finallyblock to null it out while invocation B was stillreading from it, resulting in "Cannot read properties of null (reading
'configContexts')".
Replace the shared mutable
cachewith a Symbol-keyed Map so eachinvocation gets its own isolated cache. The tsconfig disk cache is shared
across invocations with an idempotent initialization guard.
CLOSES NXC-3971