Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 14067f2 |
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 14067f2 |
|
View your CI Pipeline Execution ↗ for commit 14067f2
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JasonWeinzierl
force-pushed
the
support-eslint-v10
branch
from
dacfff1 to
0c1c3ba
Compare
leosvelperez
force-pushed
the
support-eslint-v10
branch
from
0c1c3ba to
730cf15
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our analysis indicates this failure is unrelated to the ESLint v10 changes in this PR. The failing Gradle plugin e2e test is experiencing a Gradle daemon socket timeout ("Timed out waiting for finished message from client socket connection"), which is a test infrastructure issue not introduced by the ESLint module loading changes in this PR.
No code changes were suggested for this issue.
You can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
leosvelperez
force-pushed
the
support-eslint-v10
branch
2 times, most recently
from
e3b1968 to
6e02baf
Compare
jaysoo
left a comment
jaysoo
left a comment
There was a problem hiding this comment.
The approach is correct — using loadESLint() (available since ESLint 8.57.0) as the primary path and falling back to the removed FlatESLint/LegacyESLint imports for older versions.
One gap: the existing tests only exercise the legacy fallback path. Could you add a test that mocks loadESLint() to verify the new primary code path works correctly? That would give confidence the happy path is covered.
Otherwise this looks good and is the right way to handle ESLint v10 compatibility.
JasonWeinzierl
force-pushed
the
support-eslint-v10
branch
from
6e02baf to
14067f2
Compare
|
Tests added on both eslintrc and flat paths. |
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior `@nx/eslint` relies on ESLint internals that changed in ESLint v10 (`use-at-your-own-risk`), which causes failures. It looks like #24632 originally attempted to use `loadESLint()` which would've been forward compatible with v10, but it was later removed in #27404 in favor of the `use-at-your-own-risk` import. ## Expected Behavior `@nx/eslint` supports ESLint v10. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #34415 (cherry picked from commit 31dad41)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior `@nx/eslint` relies on ESLint internals that changed in ESLint v10 (`use-at-your-own-risk`), which causes failures. It looks like #24632 originally attempted to use `loadESLint()` which would've been forward compatible with v10, but it was later removed in #27404 in favor of the `use-at-your-own-risk` import. ## Expected Behavior `@nx/eslint` supports ESLint v10. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #34415 (cherry picked from commit 31dad41)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
3 participants
Current Behavior
@nx/eslintrelies on ESLint internals that changed in ESLint v10 (use-at-your-own-risk), which causes failures.It looks like #24632 originally attempted to use
loadESLint()which would've been forward compatible with v10, but it was later removed in #27404 in favor of theuse-at-your-own-riskimport.Expected Behavior
@nx/eslintsupports ESLint v10.Related Issue(s)
Fixes #34415