fix(angular): use SASS indented syntax in nx-welcome component when style is sass#34510
Merged
fix(angular): use SASS indented syntax in nx-welcome component when style is sass#34510
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit cc3e166
☁️ Nx Cloud last updated this comment at |
…tyle is sass The nx-welcome component inline styles were always using CSS/SCSS syntax (with braces and semicolons) regardless of the selected style option. When --style=sass is chosen, the component now correctly uses SASS indented syntax (no braces or semicolons) matching the expected behavior for the .sass file format.
Coly010
force-pushed
the
angular-css-sass
branch
from
52b4abb to
cc3e166
Compare
leosvelperez
approved these changes
Feb 23, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…tyle is sass (#34510) The nx-welcome component inline styles were always using CSS/SCSS syntax (with braces and semicolons) regardless of the selected style option. When --style=sass is chosen, the component now correctly uses SASS indented syntax (no braces or semicolons) matching the expected behavior for the .sass file format. Fixes #33489 (cherry picked from commit 6bcaa46)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…tyle is sass (#34510) The nx-welcome component inline styles were always using CSS/SCSS syntax (with braces and semicolons) regardless of the selected style option. When --style=sass is chosen, the component now correctly uses SASS indented syntax (no braces or semicolons) matching the expected behavior for the .sass file format. Fixes #33489 (cherry picked from commit 6bcaa46)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nx-welcome component inline styles were always using CSS/SCSS syntax
(with braces and semicolons) regardless of the selected style option.
When --style=sass is chosen, the component now correctly uses SASS
indented syntax (no braces or semicolons) matching the expected
behavior for the .sass file format.
Fixes #33489