fix(maven): fix set the pom file without changing base directory#34182
Merged
jaysoo merged 4 commits intonrwl:masterfrom Feb 26, 2026
Merged
fix(maven): fix set the pom file without changing base directory#34182jaysoo merged 4 commits intonrwl:masterfrom
jaysoo merged 4 commits intonrwl:masterfrom
Conversation
altaiezior
requested review from
FrozenPandaz,
MaxKless and
lourw
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs canceled.
|
Contributor
Author
|
@FrozenPandaz would request your review on this one as a fix to the current nx-maven-plugin |
lourw
approved these changes
Feb 7, 2026
✅ Deploy Preview for nx-dev canceled.
|
Contributor
Author
|
@lourw @FrozenPandaz this is a simple change, can we plan for its release in the next release? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
View your CI Pipeline Execution ↗ for commit 3f6e40e
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
) ## Current Behavior nx-maven-plugin 0.0.12 is also changing the base directory along with the pom file when the plugins like flatten-maven-plugin / maven-shade-plugin produces pomFile in different directory other than the base directory ## Expected Behavior plugin should only update the pom file and not the base directory location ## Related Issue(s) Fixes #34181 mojohaus/flatten-maven-plugin#50 Co-authored-by: anurag.ag <[email protected]> (cherry picked from commit dcfc213)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
) ## Current Behavior nx-maven-plugin 0.0.12 is also changing the base directory along with the pom file when the plugins like flatten-maven-plugin / maven-shade-plugin produces pomFile in different directory other than the base directory ## Expected Behavior plugin should only update the pom file and not the base directory location ## Related Issue(s) Fixes #34181 mojohaus/flatten-maven-plugin#50 Co-authored-by: anurag.ag <[email protected]> (cherry picked from commit dcfc213)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx-maven-plugin 0.0.12 is also changing the base directory along with the pom file when the plugins like flatten-maven-plugin / maven-shade-plugin produces pomFile in different directory other than the base directory
Expected Behavior
plugin should only update the pom file and not the base directory location
Related Issue(s)
Fixes #34181
mojohaus/flatten-maven-plugin#50