Skip to content

fix(core): avoid panic when inline tui can't init#34135

Merged
AgentEnder merged 1 commit intomasterfrom
fix/fail-soft-inline-tui-init
Jan 18, 2026
Merged

fix(core): avoid panic when inline tui can't init#34135
AgentEnder merged 1 commit intomasterfrom
fix/fail-soft-inline-tui-init

Conversation

@AgentEnder
Copy link
Copy Markdown
Member

@AgentEnder AgentEnder commented Jan 16, 2026

Current Behavior

if inline tui init fails, we panic

Expected Behavior

If inline tui init fails, inline mode is disabled. We show the reason its disabled when someone tries to use it.

Related Issue(s)

Fixes #

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 18, 2026 3:35am

Request Review

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 16, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 166efc3
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/696c5348ca23d900078f6e69
😎 Deploy Preview https://deploy-preview-34135--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jan 16, 2026

View your CI Pipeline Execution ↗ for commit 166efc3

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 39m 49s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 46s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-18 04:12:43 UTC

@AgentEnder AgentEnder force-pushed the fix/fail-soft-inline-tui-init branch 2 times, most recently from a9b71a4 to e00e2bf Compare January 16, 2026 23:26
nx-cloud[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

This CI failure appears to be related to the environment or external dependencies rather than your code changes.

No code changes were suggested for this issue.

🔂 A CI rerun has been triggered by adding an empty commit to this branch.

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@AgentEnder AgentEnder force-pushed the fix/fail-soft-inline-tui-init branch from 1876681 to 166efc3 Compare January 18, 2026 03:28
@AgentEnder AgentEnder merged commit 0137ea2 into master Jan 18, 2026
20 checks passed
@AgentEnder AgentEnder deleted the fix/fail-soft-inline-tui-init branch January 18, 2026 04:38
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants