Skip to content

fix(core): prevent task hashing when project graph has errors#34116

Merged
FrozenPandaz merged 2 commits intomasterfrom
fix/prevent-hashing-on-graph-error
Jan 16, 2026
Merged

fix(core): prevent task hashing when project graph has errors#34116
FrozenPandaz merged 2 commits intomasterfrom
fix/prevent-hashing-on-graph-error

Conversation

@FrozenPandaz
Copy link
Copy Markdown
Contributor

Current Behavior

When the daemon encounters a project graph error during task hashing, it extracts the partial project graph from the error and continues hashing tasks. This can produce incorrect hashes since the graph is incomplete.

Expected Behavior

The error should be thrown immediately, preventing any hashing attempts with an invalid project graph. This ensures we don't produce incorrect task hashes that could lead to cache issues.

Related Issue(s)

N/A - Bug fix discovered during development

Previously, when the daemon encountered a project graph error, it would
extract the partial project graph from the error and continue hashing
tasks. This could produce incorrect hashes since the graph was incomplete.

Now the error is thrown immediately, preventing any hashing attempts
with an invalid project graph.
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner January 15, 2026 19:48
@FrozenPandaz FrozenPandaz requested a review from MaxKless January 15, 2026 19:48
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 15, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit da9b4c9
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/696aaae8028d0f0008286512
😎 Deploy Preview https://deploy-preview-34116--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 16, 2026 9:24pm

Request Review

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jan 15, 2026

View your CI Pipeline Execution ↗ for commit da9b4c9

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 55m 40s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 44s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-16 22:18:15 UTC

@FrozenPandaz FrozenPandaz merged commit 4202f2c into master Jan 16, 2026
19 checks passed
@FrozenPandaz FrozenPandaz deleted the fix/prevent-hashing-on-graph-error branch January 16, 2026 23:30
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants