fix(release): ensure emoji is not repeated in breaking changes summary#33605
fix(release): ensure emoji is not repeated in breaking changes summary#33605
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit c394154
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
✅ The fix from Nx Cloud was applied
These changes fix the failing e2e tests by updating the snapshots to align with the PR's intentional behavior change. The PR successfully removes the duplicate
Suggested Fix changes
diff --git a/e2e/release/src/conventional-commits-config.test.ts b/e2e/release/src/conventional-commits-config.test.ts
index 40f183a91f..de71df6881 100644
--- a/e2e/release/src/conventional-commits-config.test.ts
+++ b/e2e/release/src/conventional-commits-config.test.ts
@@ -399,7 +399,7 @@ describe('nx release conventional commits config', () => {
### ⚠️ Breaking Changes
- - ⚠️ **{project-name}:** this is a breaking change
+ - **{project-name}:** this is a breaking change
`);
const pkg2Changelog = readFile(`${pkg2}/CHANGELOG.md`);
diff --git a/e2e/release/src/conventional-commits-config.workspaces.test.ts b/e2e/release/src/conventional-commits-config.workspaces.test.ts
index 7365cfced6..e5197c9e01 100644
--- a/e2e/release/src/conventional-commits-config.workspaces.test.ts
+++ b/e2e/release/src/conventional-commits-config.workspaces.test.ts
@@ -406,7 +406,7 @@ describe('nx release conventional commits config', () => {
### ⚠️ Breaking Changes
- - ⚠️ **{project-name}:** this is a breaking change
+ - **{project-name}:** this is a breaking change
`);
const pkg2Changelog = readFile(`${pkg2}/CHANGELOG.md`);
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: Coly010 <[email protected]>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
Current Behavior
The⚠️ emoji at the beginning of bc commits is duplicated in the bc section of the changelog.
This is unneeded.
Expected Behavior
Ensure the⚠️ is not repeated in the bc section of the changelog