fix(core): prevent hanging between command end and process exit#33500
Merged
FrozenPandaz merged 1 commit intomasterfrom Nov 17, 2025
Merged
fix(core): prevent hanging between command end and process exit#33500FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 7eb8ad8
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+13
to
+16
| if ( | ||
| chunk.codePointAt(chunk.length - 1) === VERY_END_CODE && | ||
| message.endsWith(MESSAGE_END_SEQ) | ||
| ) { |
Contributor
There was a problem hiding this comment.
The current condition may not correctly detect message endings in all cases. The check chunk.codePointAt(chunk.length - 1) === VERY_END_CODE only examines the last character of the current chunk, but the EOT character could have arrived in a previous chunk with the rest of the MESSAGE_END_SEQ arriving in the current chunk.
Consider one of these alternatives:
- Simply use
if (message.endsWith(MESSAGE_END_SEQ))which already handles the complete check - If the preliminary character check is intended as an optimization, use
if (message.charAt(message.length - 1).codePointAt(0) === VERY_END_CODE && message.endsWith(MESSAGE_END_SEQ))
This ensures the message ending is detected correctly regardless of how the data is chunked during transmission.
Suggested change
| if ( | |
| chunk.codePointAt(chunk.length - 1) === VERY_END_CODE && | |
| message.endsWith(MESSAGE_END_SEQ) | |
| ) { | |
| if ( | |
| message.charAt(message.length - 1).codePointAt(0) === VERY_END_CODE && | |
| message.endsWith(MESSAGE_END_SEQ) | |
| ) { |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
FrozenPandaz
approved these changes
Nov 17, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 17, 2025
## Current Behavior In certain scenarios, Nx commands would hang between command completion and process exit. This was caused by inefficient message end detection in the daemon socket communication, where the check for `MESSAGE_END_SEQ` could fail when TCP packets were fragmented. ## Expected Behavior With this PR, the message end detection is more robust and handles TCP packet fragmentation correctly, preventing the hanging issue. The changes also add better performance tracking and logging to help diagnose similar issues in the future. ## Changes Made - **Improved message end detection** (`consume-messages-from-socket.ts`): Added a preliminary check of the last character's code point before checking the full MESSAGE_END_SEQ, which prevents false negatives when TCP packets are fragmented - **Enhanced performance tracking** (`daemon/client/client.ts`, `daemon-socket-messenger.ts`): Added message-type-specific performance marks and measures for better debugging - **Added server-side logging** (`daemon/server/server.ts`): Added logging for message receipt, serialization, and response to help diagnose communication issues ## Related Issue(s) This fix addresses hanging issues observed in daemon communication when commands complete but the process doesn't exit. (cherry picked from commit d86fb5d)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
In certain scenarios, Nx commands would hang between command completion and process exit. This was caused by inefficient message end detection in the
daemon socket communication, where the check for
MESSAGE_END_SEQcould fail when TCP packets were fragmented.Expected Behavior
With this PR, the message end detection is more robust and handles TCP packet fragmentation correctly, preventing the hanging issue. The changes also
add better performance tracking and logging to help diagnose similar issues in the future.
Changes Made
consume-messages-from-socket.ts): Added a preliminary check of the last character's code point before checkingthe full MESSAGE_END_SEQ, which prevents false negatives when TCP packets are fragmented
daemon/client/client.ts,daemon-socket-messenger.ts): Added message-type-specific performance marks andmeasures for better debugging
daemon/server/server.ts): Added logging for message receipt, serialization, and response to help diagnosecommunication issues
Related Issue(s)
This fix addresses hanging issues observed in daemon communication when commands complete but the process doesn't exit.