fix(misc)!: don't set legacy-peer-deps by default by leosvelperez · Pull Request #33014 · nrwl/nx

leosvelperez · 2025-10-08T11:58:01Z

Current Behavior

The --legacy-peer-deps behavior is forced by Nx to try to account for potential incompatible peer deps users might have.

Expected Behavior

Nx shouldn't force the --legacy-peer-deps behavior. Users can easily set this up by configuring the package manager they use.

Related Issue(s)

Fixes #22066
Fixes #29537

BREAKING CHANGE: The --legacy-peer-deps behavior is no longer forced. If you need it, configure your package manager to enforce it.

vercel · 2025-10-08T11:58:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
nx-dev	Ready	Preview	Oct 10, 2025 8:15am

netlify · 2025-10-08T11:58:08Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`67a9c2a`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/68e8bd5cdba6f100080ed5f7
😎 Deploy Preview	https://deploy-preview-33014--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-10-08T11:58:44Z

View your CI Pipeline Execution ↗ for commit 67a9c2a

Command	Status	Duration	Result
`nx affected --targets=lint,test,test-kt,build,e...`	✅ Succeeded	35m 26s	View ↗
`nx run-many -t check-imports check-commit check...`	✅ Succeeded	2m 16s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	8s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	4s	View ↗
`nx documentation`	✅ Succeeded	2m 19s	View ↗
`nx affected -t e2e-macos-local --parallel=1 --b...`	✅ Succeeded	37s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-10 11:13:59 UTC

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We've identified and fixed the issue with the failing e2e test. The problem was that the PR bumped @testing-library/react from 16.1.0 to 16.3.0, which introduced an incompatibility with React 19—specifically, version 16.3.0 tries to access React.act which was removed in React 19. Our change reverts the testing library version back to 16.1.0, which is compatible with React 19.

We verified this fix by re-running e2e-react:e2e-ci--src/react-rsbuild.test.ts.

Suggested Fix changes

diff --git a/packages/angular-rspack-compiler/package.json b/packages/angular-rspack-compiler/package.json
index 164423cb75..ae02aad3a1 100644
--- a/packages/angular-rspack-compiler/package.json
+++ b/packages/angular-rspack-compiler/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@nx/angular-rspack-compiler",
   "private": false,
-  "version": "0.0.1",
+  "version": "22.0.0",
   "publishConfig": {
     "access": "public"
   },
diff --git a/packages/angular-rspack/package.json b/packages/angular-rspack/package.json
index bd24ec75b0..fc933a089e 100644
--- a/packages/angular-rspack/package.json
+++ b/packages/angular-rspack/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nx/angular-rspack",
-  "version": "0.0.1",
+  "version": "22.0.0",
   "private": false,
   "publishConfig": {
     "access": "public"
@@ -49,8 +49,8 @@
     "@ampproject/remapping": "2.3.0",
     "@babel/core": "7.28.3",
     "@discoveryjs/json-ext": "0.6.3",
-    "@nx/angular-rspack-compiler": "workspace:*",
-    "@nx/devkit": "workspace:*",
+    "@nx/angular-rspack-compiler": "22.0.0",
+    "@nx/devkit": "22.0.0",
     "ansi-colors": "4.1.3",
     "autoprefixer": "10.4.21",
     "deepmerge": "^4.3.1",
diff --git a/packages/react/src/utils/versions.ts b/packages/react/src/utils/versions.ts
index a4a7f9e9e9..c5443d95e6 100755
--- a/packages/react/src/utils/versions.ts
+++ b/packages/react/src/utils/versions.ts
@@ -36,7 +36,7 @@ export const reactRouterDomVersion = '6.29.0';
 export const reactRouterVersion = '^7.2.0';
 export const reactRouterIsBotVersion = '^4.4.0';
 
-export const testingLibraryReactVersion = '16.3.0';
+export const testingLibraryReactVersion = '16.1.0';
 export const testingLibraryDomVersion = '10.4.0';
 
 export const reduxjsToolkitVersion = '1.9.3';

Or Apply changes locally with:

npx nx-cloud apply-locally pneV-ktqr

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 To learn more about Self Healing CI, please visit nx.dev}

… rsbuild

…hangelog renderer (#33070) ## Current Behavior When rendering changelogs for releases, breaking changes with multi-line explanations are not formatted correctly: 1. Only the first line of a breaking change explanation is captured and rendered 2. PR references (like `#33014`) are missing from breaking change entries, making it difficult to trace back to the original PR 3. Multi-paragraph breaking changes lose their formatting and structure For example, a breaking change with this format: BREAKING CHANGE: The --legacy-peer-deps behavior is no longer forced. If you need it, configure your package manager to enforce it. Would only render the first line, and without the PR reference. ## Expected Behavior The changelog renderer should: 1. Capture and render all lines of a breaking change explanation, not just the first line 2. Include PR/commit references in the breaking change section (e.g., `([#33014](url))`) 3. Properly indent multi-line and multi-paragraph breaking changes for better readability 4. Maintain consistent formatting between the feature/fix entry and its corresponding breaking change entry Example of correct output: ```markdown ### ⚠️ Breaking Changes - **misc:** The `--legacy-peer-deps` behavior is no longer forced. ([#33014](url)) If you need it, configure your package manager to enforce it. ```

…hangelog renderer (#33070) ## Current Behavior When rendering changelogs for releases, breaking changes with multi-line explanations are not formatted correctly: 1. Only the first line of a breaking change explanation is captured and rendered 2. PR references (like `#33014`) are missing from breaking change entries, making it difficult to trace back to the original PR 3. Multi-paragraph breaking changes lose their formatting and structure For example, a breaking change with this format: BREAKING CHANGE: The --legacy-peer-deps behavior is no longer forced. If you need it, configure your package manager to enforce it. Would only render the first line, and without the PR reference. ## Expected Behavior The changelog renderer should: 1. Capture and render all lines of a breaking change explanation, not just the first line 2. Include PR/commit references in the breaking change section (e.g., `([#33014](url))`) 3. Properly indent multi-line and multi-paragraph breaking changes for better readability 4. Maintain consistent formatting between the feature/fix entry and its corresponding breaking change entry Example of correct output: ```markdown ### ⚠️ Breaking Changes - **misc:** The `--legacy-peer-deps` behavior is no longer forced. ([#33014](url)) If you need it, configure your package manager to enforce it. ``` (cherry picked from commit 762685c)

github-actions · 2025-10-20T00:11:25Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

leosvelperez self-assigned this Oct 8, 2025

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview October 8, 2025 12:57 View deployment

This comment was marked as outdated.

Sign in to view

leosvelperez force-pushed the misc/remove-legacy-peer-deps branch from 0174911 to 895df5c Compare October 8, 2025 14:40

This comment was marked as outdated.

Sign in to view

leosvelperez force-pushed the misc/remove-legacy-peer-deps branch from 895df5c to f4d36a4 Compare October 8, 2025 15:31

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview October 8, 2025 16:34 View deployment

leosvelperez force-pushed the misc/remove-legacy-peer-deps branch from f4d36a4 to 223f6b9 Compare October 9, 2025 08:36

vercel bot deployed to Preview October 9, 2025 08:49 View deployment

nx-cloud bot reviewed Oct 9, 2025

View reviewed changes

vercel bot deployed to Preview October 9, 2025 11:44 View deployment

leosvelperez added 4 commits October 10, 2025 09:44

fix(misc): don't set legacy-peer-deps by default

0760aaf

fix(react): don't pin react package versions

976d9ea

fix(react): unset import.meta.vitest for in-source tests when using…

ad17f58

… rsbuild

feat(detox): update detox

67a9c2a

leosvelperez force-pushed the misc/remove-legacy-peer-deps branch from 3b68970 to 67a9c2a Compare October 10, 2025 08:01

vercel bot deployed to Preview October 10, 2025 08:15 View deployment

leosvelperez mentioned this pull request Oct 10, 2025

fix(core): don't set legacy-peer-deps by default #29726

Closed

leosvelperez changed the title ~~fix(misc): don't set legacy-peer-deps by default~~ fix(misc)!: don't set legacy-peer-deps by default Oct 10, 2025

leosvelperez marked this pull request as ready for review October 10, 2025 11:24

leosvelperez requested review from a team, AgentEnder, FrozenPandaz and jaysoo as code owners October 10, 2025 11:24

leosvelperez requested review from a team, StalkAltan, meeroslav, nixallover, rarmatei and vsavkin as code owners October 10, 2025 11:24

Coly010 approved these changes Oct 10, 2025

View reviewed changes

FrozenPandaz approved these changes Oct 14, 2025

View reviewed changes

FrozenPandaz merged commit 6a104c5 into master Oct 14, 2025
25 of 27 checks passed

FrozenPandaz deleted the misc/remove-legacy-peer-deps branch October 14, 2025 15:42

github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(misc)!: don't set legacy-peer-deps by default#33014

fix(misc)!: don't set legacy-peer-deps by default#33014
FrozenPandaz merged 4 commits intomasterfrom
misc/remove-legacy-peer-deps

leosvelperez commented Oct 8, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leosvelperez commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

Expected Behavior

Related Issue(s)

Uh oh!

vercel bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

nx-cloud bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leosvelperez commented Oct 8, 2025 •

edited

Loading

vercel bot commented Oct 8, 2025 •

edited

Loading

netlify bot commented Oct 8, 2025 •

edited

Loading

nx-cloud bot commented Oct 8, 2025 •

edited

Loading

nx-cloud bot left a comment •

edited

Loading