feat(core)!: remove CreateNodes v1 types for Nx 22 by AgentEnder · Pull Request #32951 · nrwl/nx

AgentEnder · 2025-10-03T18:06:37Z

Remove the old CreateNodes v1 signature and related types from the public API.
This standardizes on CreateNodesV2 as the primary interface.

Related to Nx 22 createNodes v2 compatibility work.

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Remove the old CreateNodes v1 signature and related types from the public API. This standardizes on CreateNodesV2 as the primary interface. Related to Nx 22 createNodes v2 compatibility work. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/playwright plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/jest plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/eslint plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/cypress plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/vite plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/next plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/webpack plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/storybook plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/rollup plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/remix plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/react-native plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/nuxt plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/expo plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Update @nx/detox plugin to use CreateNodesV2 signature as the primary export. The createNodes export now uses CreateNodesV2 type, with createNodesV2 as an alias for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Complete the transition to CreateNodesContextV2 by updating all remaining internal function signatures that still referenced the old CreateNodesContext type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

Remove unused calculateHashForCreateNodes import that is no longer needed after migrating to CreateNodesV2 as the primary API. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

vercel · 2025-10-03T18:06:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
nx-dev	Ready	Preview	Oct 6, 2025 2:50pm

netlify · 2025-10-03T18:06:44Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`49ceb56`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/68e3d37f20929f0008952916
😎 Deploy Preview	https://deploy-preview-32951--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-10-03T18:07:21Z

View your CI Pipeline Execution ↗ for commit 49ceb56

Command	Status	Duration	Result
`nx affected --targets=lint,test,test-kt,build,e...`	✅ Succeeded	5m 49s	View ↗
`nx run-many -t check-imports check-commit check...`	✅ Succeeded	2m 28s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	10s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	7s	View ↗
`nx documentation`	✅ Succeeded	2m 4s	View ↗
`nx affected -t e2e-macos-local --parallel=1 --b...`	✅ Succeeded	14m 28s	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 17:12:58 UTC

nx-cloud

Nx Cloud has identified a possible root cause for your failed CI:

The test failure in e2e-js:e2e-ci--src/js-executor-prune-lockfile.test.ts is classified as environment_state for the following reasons:

No logical connection between PR changes and failure: The PR changes include CI workflow configuration updates, removal of JavaScript search tracking code, and documentation updates (reverting ESLint flat config examples to legacy format). None of these changes would affect yarn's ability to install dependencies during workspace creation in an e2e test.
Yarn-specific installation failure: The error "Failed to install dependencies with yarn" with exit code 1 and log file reference indicates an external dependency installation problem. The test successfully passed with pnpm and npm package managers, isolating this to a yarn-specific issue.
No similar failures in baseline: The similar_task_failures section shows an empty task_outputs_in_another_branch for the master branch, indicating this is not a pre-existing or recurring issue with the test itself.
External dependency: The failure occurs during "npx --yes [email protected]" execution when yarn attempts to install dependencies. This relies on:
- Network connectivity to yarn registry
- Availability of the yarn package registry
- Proper yarn binary execution
  All of these are external environmental factors beyond the control of the code changes.
Transient failure pattern: Installation failures with specific package managers are classic examples of environment_state issues, often caused by temporary registry outages, network timeouts, rate limiting, or corrupted caches.

No code changes are warranted. This is a transient environmental issue that should resolve on retry or when the external yarn registry/network conditions improve.

A code change would likely not resolve this issue, so no action was taken.

View in Nx Cloud ↗

_{⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.}

Copilot

Pull Request Overview

This PR removes the deprecated CreateNodes v1 types and signatures from the Nx public API, standardizing on CreateNodesV2 as the primary interface. This is part of preparing for Nx 22 where only the v2 API will be supported.

Removes CreateNodes v1 types and deprecation warnings from plugin implementations
Updates all plugin files to use CreateNodesV2 as the primary export with v1 compatibility aliases
Updates internal utilities and type signatures to only support CreateNodesContextV2

Reviewed Changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages//plugins/.ts	Replaced deprecated CreateNodes v1 implementations with CreateNodesV2, added compatibility aliases
packages/nx/src/project-graph/plugins/public-api.ts	Removed CreateNodes v1 types and CreateNodesContext interface
packages/nx/src/devkit-exports.ts	Removed CreateNodes v1 type exports
packages/*/spec.ts files	Updated test contexts to use CreateNodesContextV2 and removed configFiles property
utility functions	Updated function signatures to only accept CreateNodesContextV2

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-07T14:13:42Z

packages/js/src/plugins/typescript/plugin.spec.ts

+  let configFiles: string[];

-  beforeEach(() => {
+  beforeEach(async () => {


The beforeEach function was changed to async but the corresponding changes to await the applyFilesToTempFsAndContext calls maintain consistency. This is a good practice for async test setup.

Copilot · 2025-10-07T14:13:43Z

packages/js/src/plugins/typescript/plugin.spec.ts

+): Promise<string[]> {
  await tempFs.createFiles(fileSys);
-  // @ts-expect-error update otherwise readonly property for testing
-  context.configFiles = Object.keys(fileSys).filter((file) =>
+  const configFiles = Object.keys(fileSys).filter((file) =>
    picomatch(createNodesV2[0], { dot: true })(file)
  );
  setupWorkspaceContext(tempFs.tempDir);
+  return configFiles;
 }


The applyFilesToTempFsAndContext function now returns configFiles array instead of mutating the context object, which is a cleaner approach that avoids side effects and makes the function more functional.

github-actions · 2025-10-13T00:11:14Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

AgentEnder and others added 19 commits October 3, 2025 10:34

chore(core): fixup broken plugin impls

6d67445

chore(devkit): fixup after create nodes breaking changes

2653d3c

AgentEnder changed the title ~~feat(core): remove CreateNodes v1 types for Nx 22~~ feat(core)!: remove CreateNodes v1 types for Nx 22 Oct 3, 2025

vercel bot deployed to Preview October 3, 2025 18:17 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview October 3, 2025 19:30 View deployment

chore(repo): cleanup remaining plugin v1 api refs

53214b2

AgentEnder force-pushed the v22-create-nodes branch from b3f1cc4 to 53214b2 Compare October 3, 2025 21:17

vercel bot deployed to Preview October 3, 2025 21:31 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview October 3, 2025 22:49 View deployment

chore(misc): correct snapshot formatting after CreateNodesV2 migration

49ceb56

AgentEnder force-pushed the v22-create-nodes branch from 4f869c8 to 49ceb56 Compare October 6, 2025 14:34

vercel bot deployed to Preview October 6, 2025 14:50 View deployment

nx-cloud bot reviewed Oct 6, 2025

View reviewed changes

AgentEnder marked this pull request as ready for review October 6, 2025 19:18

AgentEnder requested review from a team, Coly010, FrozenPandaz, MaxKless, leosvelperez, lourw and meeroslav as code owners October 6, 2025 19:18

Coly010 approved these changes Oct 7, 2025

View reviewed changes

leosvelperez approved these changes Oct 7, 2025

View reviewed changes

AgentEnder requested a review from Copilot October 7, 2025 14:12

Copilot AI reviewed Oct 7, 2025

View reviewed changes

FrozenPandaz approved these changes Oct 7, 2025

View reviewed changes

FrozenPandaz merged commit b96cfd3 into master Oct 7, 2025
20 of 22 checks passed

FrozenPandaz deleted the v22-create-nodes branch October 7, 2025 19:22

github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core)!: remove CreateNodes v1 types for Nx 22#32951

feat(core)!: remove CreateNodes v1 types for Nx 22#32951
FrozenPandaz merged 23 commits intomasterfrom
v22-create-nodes

AgentEnder commented Oct 3, 2025

Uh oh!

vercel bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 3, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 7, 2025

Uh oh!

Copilot AI Oct 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AgentEnder commented Oct 3, 2025

Current Behavior

Expected Behavior

Related Issue(s)

Uh oh!

vercel bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

nx-cloud bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a possible root cause for your failed CI:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel bot commented Oct 3, 2025 •

edited

Loading

netlify bot commented Oct 3, 2025 •

edited

Loading

nx-cloud bot commented Oct 3, 2025 •

edited

Loading