Skip to content

fix(core): move from execFile to exec for windows support#32836

Merged
FrozenPandaz merged 1 commit intomasterfrom
fix-provenance-windows
Sep 24, 2025
Merged

fix(core): move from execFile to exec for windows support#32836
FrozenPandaz merged 1 commit intomasterfrom
fix-provenance-windows

Conversation

@MaxKless
Copy link
Copy Markdown
Collaborator

@MaxKless MaxKless commented Sep 24, 2025

Current Behavior

provenance checks fail on latest on windows because npm.cmd is only executable with a shell. That removes the entire security aspect of using execFile so we just go back to exec.

Expected Behavior

provenance checks shouldn't fail on windows.

Related Issue(s)

Fixes #32713

@MaxKless MaxKless requested a review from a team as a code owner September 24, 2025 08:55
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Sep 24, 2025 9:06am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Sep 24, 2025

View your CI Pipeline Execution ↗ for commit f908e81

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 42m 39s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-24 09:43:59 UTC

@FrozenPandaz FrozenPandaz merged commit c915527 into master Sep 24, 2025
16 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-provenance-windows branch September 24, 2025 13:34
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use nx migrate ** cli command

2 participants