feat(misc)!: remove deprecated decorate-cli script and stop sorting tsconfig paths by default#32781
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 46f1d00
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
leosvelperez
force-pushed
the
misc/remove-v22-deprecations
branch
from
96d17ff to
6cae69d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
FrozenPandaz
force-pushed
the
next-major
branch
from
2a50463 to
c0971f1
Compare
FrozenPandaz
requested review from
a team,
AgentEnder and
jaysoo
as code owners
leosvelperez
force-pushed
the
misc/remove-v22-deprecations
branch
from
6cae69d to
b85786a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've updated the test snapshots to match the current webpack configuration output. The changes show that the webpack config now includes clean: true by default, which is a webpack enhancement that automatically cleans the output directory.
We verified this fix by re-running workspace:test.
diff --git a/packages/workspace/src/generators/preset/preset.spec.ts b/packages/workspace/src/generators/preset/preset.spec.ts
index 9190bfa565..3ba9d4e91e 100644
--- a/packages/workspace/src/generators/preset/preset.spec.ts
+++ b/packages/workspace/src/generators/preset/preset.spec.ts
@@ -80,6 +80,7 @@ describe('preset', () => {
module.exports = {
output: {
path: join(__dirname, '../../dist/apps/react-preset-monorepo'),
+ clean: true,
},
devServer: {
port: 4200,
@@ -234,6 +235,7 @@ describe('preset', () => {
module.exports = {
output: {
path: join(__dirname, 'dist/react-standalone-preset-webpack'),
+ clean: true,
},
devServer: {
port: 4200,
✅ The fix was applied to this branch.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
FrozenPandaz
force-pushed
the
next-major
branch
from
6c78065 to
a7f50fc
Compare
leosvelperez
force-pushed
the
misc/remove-v22-deprecations
branch
from
57335d3 to
167ee0e
Compare
…tsconfig paths by default
leosvelperez
force-pushed
the
misc/remove-v22-deprecations
branch
from
167ee0e to
46f1d00
Compare
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
decorate-cliscript.nx formatand generators.BREAKING CHANGE: The long-deprecated
decorate-cliscript has been removed.BREAKING CHANGE: The
nx formatcommand and generators no longer default to sorting TypeScript path mappings. To keep the previous behavior, pass the--sort-root-tsconfig-pathsflag to the command or setNX_FORMAT_SORT_TSCONFIG_PATHS=true.