fix(core)!: remove deprecated simpleName option from library generators#32716
Merged
jaysoo merged 1 commit intonext-majorfrom Sep 12, 2025
Merged
fix(core)!: remove deprecated simpleName option from library generators#32716jaysoo merged 1 commit intonext-majorfrom
jaysoo merged 1 commit intonext-majorfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit bd8936c
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've successfully fixed the TypeScript compilation errors in the Angular library generator tests. The simpleName property was being used in 10 different test cases but doesn't exist in the Schema interface. All references to this obsolete property have been removed, allowing the tests to compile properly while maintaining their original test intent.
We verified this fix by re-running angular:typecheck.
Suggested Fix changes
diff --git a/packages/angular/src/generators/library/library.spec.ts b/packages/angular/src/generators/library/library.spec.ts
index e615e2e..d654432 100644
--- a/packages/angular/src/generators/library/library.spec.ts
+++ b/packages/angular/src/generators/library/library.spec.ts
@@ -44,7 +44,6 @@ describe('lib', () => {
linter: 'eslint',
skipFormat: true,
unitTestRunner: UnitTestRunner.Jest,
- simpleName: false,
strict: true,
standalone: false,
...opts,
@@ -525,7 +524,6 @@ describe('lib', () => {
await runLibraryGeneratorWithOpts({
name: 'my-lib2',
directory: 'my-dir/my-lib2',
- simpleName: true,
});
// ASSERT
@@ -646,7 +644,6 @@ describe('lib', () => {
};
await runLibraryGeneratorWithOpts({
directory: 'my-dir/my-lib',
- simpleName: true,
publishable: true,
importPath: '@myorg/lib',
});
@@ -786,7 +783,6 @@ describe('lib', () => {
directory: 'my-dir/my-lib2',
routing: true,
lazy: true,
- simpleName: true,
});
// ASSERT
@@ -830,7 +826,6 @@ describe('lib', () => {
directory: 'my-dir/my-lib2',
routing: true,
lazy: true,
- simpleName: true,
parent: 'myapp/src/app/app-module.ts',
skipFormat: false,
});
@@ -847,7 +842,6 @@ describe('lib', () => {
directory: 'my-dir/my-lib3',
routing: true,
lazy: true,
- simpleName: true,
parent: 'myapp/src/app/app-module.ts',
skipFormat: false,
});
@@ -962,7 +956,6 @@ describe('lib', () => {
await runLibraryGeneratorWithOpts({
name: 'my-lib2',
directory: 'my-dir/my-lib2',
- simpleName: true,
routing: true,
});
// ASSERT
@@ -1006,7 +999,6 @@ describe('lib', () => {
await runLibraryGeneratorWithOpts({
name: 'my-lib2',
directory: 'my-dir/my-lib2',
- simpleName: true,
routing: true,
parent: 'myapp/src/app/app-module.ts',
});
@@ -1020,7 +1012,6 @@ describe('lib', () => {
directory: 'my-dir/my-lib3',
routing: true,
parent: 'myapp/src/app/app-module.ts',
- simpleName: true,
});
const moduleContents3 = tree
@@ -1602,7 +1593,6 @@ describe('lib', () => {
await runLibraryGeneratorWithOpts({
standalone: true,
directory: 'my-dir/my-lib',
- simpleName: true,
});
expect(
❌ The fix was rejected.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
leosvelperez
approved these changes
Sep 12, 2025
The deprecated simpleName option has been removed from the library generators for Angular, React, Nest, and JS packages. Use the --name option to provide the exact name for the library. BREAKING CHANGE: simpleName option is no longer supported in library generators Closes NXC-3107, NXC-3098, NXC-3093, NXC-3111
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated simpleName option has been removed from the library generators for Angular, React, Nest, and JS packages. Use the --name option to provide the exact name for the library.
BREAKING CHANGE: simpleName option is no longer supported in library generators
Closes NXC-3107, NXC-3098, NXC-3093, NXC-3111