Skip to content

fix(js): esm loader should handle absolute paths on windows #32376#32383

Merged
Coly010 merged 1 commit intomasterfrom
esm-loader-windows
Aug 18, 2025
Merged

fix(js): esm loader should handle absolute paths on windows #32376#32383
Coly010 merged 1 commit intomasterfrom
esm-loader-windows

Conversation

@Coly010
Copy link
Copy Markdown
Contributor

@Coly010 Coly010 commented Aug 18, 2025

Current Behavior

ESM Loader for Windows is not working because it is encountering an absolute path that is not using the file:// protocol.

Expected Behavior

Ensure that when loading the esm-loader, it uses the file protocol

Related Issue(s)

Fixes #32376

@Coly010 Coly010 requested a review from a team as a code owner August 18, 2025 11:02
@Coly010 Coly010 self-assigned this Aug 18, 2025
@Coly010 Coly010 requested a review from FrozenPandaz August 18, 2025 11:02
@vercel
Copy link
Copy Markdown

vercel bot commented Aug 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Aug 18, 2025 11:16am

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 18, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 1a2ddfa
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68a308519e6f0b0008b315ba
😎 Deploy Preview https://deploy-preview-32383--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud bot commented Aug 18, 2025

View your CI Pipeline Execution ↗ for commit 1a2ddfa

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 42m 46s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 45s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 6s View ↗
nx documentation ✅ Succeeded 1m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-18 11:51:55 UTC

@Coly010 Coly010 merged commit b5439b9 into master Aug 18, 2025
10 checks passed
@Coly010 Coly010 deleted the esm-loader-windows branch August 18, 2025 12:24
FrozenPandaz pushed a commit that referenced this pull request Aug 22, 2025
…32383)

## Current Behavior
ESM Loader for Windows is not working because it is encountering an
absolute path that is not using the `file://` protocol.

## Expected Behavior
Ensure that when loading the `esm-loader`, it uses the file protocol

## Related Issue(s)

Fixes #32376

(cherry picked from commit b5439b9)
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nest.js plugin error: ESM loader error

2 participants