fix(js): handle npm 11 warnings in stderr during registry version resolution#32223
Merged
fix(js): handle npm 11 warnings in stderr during registry version resolution#32223
Conversation
…olution npm 11+ (bundled with Node 24.3) writes deprecation warnings about unknown environment configurations to stderr even when commands succeed. The registry version resolver was incorrectly rejecting any npm view command with stderr content, causing e2e tests to fail with Node 24.3. This change updates the error handling to only reject on actual errors, ignoring npm warning messages that start with 'npm warn'.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 552a885
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Aug 5, 2025
This was referenced Aug 6, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behaviour
E2e tests fail with Node 24 because npm 11 writes deprecation warnings to stderr even on successful commands, causing registry version resolution to fail.
Expected Behaviour
Registry version resolution should work with npm 11 warnings in stderr.
References
https://staging.nx.app/runs/l9kRV3E6ST