fix(angular): generate ngrx facade spec file correctly#31850
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 293c349
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jul 10, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 11, 2025
## Current Behavior When generating a facade with the NgRx generators, the spec file imports a non-existent `readFirst` from `@nx/angular/testing`. That helper was deprecated for a long time and removed in Nx v21, but this usage was missed, causing those tests to fail. The e2e tests that cover this were disabled for the pnpm package manager, so it was not caught in the PR/main CI pipeline. It was correctly failing in the Nightly CI pipeline. The tests are now enabled for all package managers. Nightly failure: https://staging.nx.app/runs/uRlR20Fzt9/task/e2e-angular%3Ae2e-local ## Expected Behavior When generating a facade with the NgRx generators, the spec file for the facade should be correct. ## Related Issue(s) Fixes # (cherry picked from commit b8f1390)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When generating a facade with the NgRx generators, the spec file imports a non-existent
readFirstfrom@nx/angular/testing. That helper was deprecated for a long time and removed in Nx v21, but this usage was missed, causing those tests to fail.The e2e tests that cover this were disabled for the pnpm package manager, so it was not caught in the PR/main CI pipeline. It was correctly failing in the Nightly CI pipeline. The tests are now enabled for all package managers.
Nightly failure: https://staging.nx.app/runs/uRlR20Fzt9/task/e2e-angular%3Ae2e-local
Expected Behavior
When generating a facade with the NgRx generators, the spec file for the facade should be correct.
Related Issue(s)
Fixes #