fix(core): handle killing child processes of continuous tasks on Windows#31296
Merged
fix(core): handle killing child processes of continuous tasks on Windows#31296
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
|
View your CI Pipeline Execution ↗ for commit b493916.
☁️ Nx Cloud last updated this comment at |
Cammisuli
approved these changes
May 21, 2025
jaysoo
force-pushed
the
fix/windows-process-kill
branch
from
459fdfc to
35ea15f
Compare
jaysoo
force-pushed
the
fix/windows-process-kill
branch
from
35ea15f to
b493916
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where running
nx e2e <proj>on Windows does not kill the underlying dev/preview server when the e2e task ends.Repro:
npx create-nx-workspace@latest repro --preset=react-monorepo --e2eTestRunner=playwright --appName=democd repro && npx nx e2e demo-e2eThis will leave the preview server running on port
4300, and you have tonetstat -ano | findstr :4300to find the PID and kill it.https://www.loom.com/share/fcbea53cdff543a98f4d4c8377027ee0
Current Behavior
Continuous task does not kill the process correctly once discrete task ends.
Expected Behavior
Processes are killed correctly once task is done running.
Related Issue(s)
Fixes #31235