feat(core)!: drop support for create nodes v1 in favor of only calling create nodes v2#30616
Merged
AgentEnder merged 2 commits intomasterfrom Apr 28, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
View your CI Pipeline Execution ↗ for commit d817d71.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
next-major
branch
10 times, most recently
from
9a4c671 to
cf7cc52
Compare
AgentEnder
requested review from
a team,
bcabanes,
jaysoo,
philipjfulcher,
vsavkin and
xiongemi
as code owners
Member
Author
|
Apologies for the extra review requests... rebase on next-major went wonky and decided I needed everyone 🤦 |
AgentEnder
force-pushed
the
feat/remove-create-nodes-v1-next-major
branch
from
ae6dade to
958d7d7
Compare
AgentEnder
force-pushed
the
feat/remove-create-nodes-v1-next-major
branch
from
958d7d7 to
821a10e
Compare
AgentEnder
force-pushed
the
feat/remove-create-nodes-v1-next-major
branch
from
821a10e to
fb22afd
Compare
FrozenPandaz
approved these changes
Apr 25, 2025
| this.exclude = pluginDefinition.exclude; | ||
| } | ||
|
|
||
| if (plugin.createNodes && !plugin.createNodesV2) { |
Collaborator
There was a problem hiding this comment.
We should throw an error here to let plugin authors know that their plugin is incompatible with Nx 21. They have already been notified via tsdoc deprecations.
AgentEnder
force-pushed
the
feat/remove-create-nodes-v1-next-major
branch
2 times, most recently
from
6faf02d to
c7c3b5d
Compare
BREAKING CHANGE: Removes support for v1 of the create nodes API. Plugins need to migrate to createNodesV2 for nx 21 support
AgentEnder
force-pushed
the
feat/remove-create-nodes-v1-next-major
branch
from
c7c3b5d to
d817d71
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Plugins will need to migrate to create nodes v2 if they haven't already to stay supported.
Current Behavior
Currently if a plugin exports only
createNodes, we adapt it to acreateNodesV2under the hood and run it. If a plugin exports both, we only run the v2 api.Future Behavior
In the future we want
createNodesV2to becomecreateNodes. To facilitate this transition for the duration of Nx 21,createNodeswill not be invoked. This gives plugin authors time to migrate over to the v2 spec and export it fromcreateNodessuch that it will be ready to be called in the future.