Skip to content

feat(expo): upgrade Expo to v52#29142

Merged
xiongemi merged 1 commit into
masterfrom
hassankhan/expo-v52
Dec 12, 2024
Merged

feat(expo): upgrade Expo to v52#29142
xiongemi merged 1 commit into
masterfrom
hassankhan/expo-v52

Conversation

@xiongemi
Copy link
Copy Markdown
Contributor

@xiongemi xiongemi commented Dec 2, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner December 2, 2024 04:28
@xiongemi xiongemi requested a review from mandarini December 2, 2024 04:28
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 5:35am

@xiongemi xiongemi mentioned this pull request Dec 2, 2024
Closed
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 373cc88. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the hassankhan/expo-v52 branch 4 times, most recently from d7413cf to fb21d22 Compare December 2, 2024 18:16
@yonitou
Copy link
Copy Markdown

yonitou commented Dec 3, 2024

Hi !
When do you think it will be released ?

@hassankhan
Copy link
Copy Markdown
Contributor

hassankhan commented Dec 4, 2024

Thanks for taking a look @xiongemi, I'll try and test out the PR this weekend

@hassankhan
Copy link
Copy Markdown
Contributor

hassankhan commented Dec 6, 2024

@xiongemi Got a chance to test it, its working perfectly for me 💯

@hassankhan
Copy link
Copy Markdown
Contributor

hassankhan commented Dec 6, 2024

It might be worth updating Expo to 52.0.16 because of some issues with Expo Router and Sentry though: expo/expo#33344

@bennnjamin
Copy link
Copy Markdown

bennnjamin commented Dec 6, 2024

Will this allow us to upgrade projects created with @nx/expo with expo 51 to expo 52?

@hassankhan
Copy link
Copy Markdown
Contributor

hassankhan commented Dec 8, 2024

@bennnjamin It will

@xiongemi xiongemi force-pushed the hassankhan/expo-v52 branch 2 times, most recently from 9af7d4d to f00f874 Compare December 11, 2024 20:57
@xiongemi xiongemi force-pushed the hassankhan/expo-v52 branch from f00f874 to 373cc88 Compare December 12, 2024 05:33
@xiongemi
Copy link
Copy Markdown
Contributor Author

xiongemi commented Dec 12, 2024

Hi ! When do you think it will be released ?

it should be in 20.3.0

@xiongemi xiongemi merged commit a0f4260 into master Dec 12, 2024
@xiongemi xiongemi deleted the hassankhan/expo-v52 branch December 12, 2024 18:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 18, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mandarini mandarini Awaiting requested review from mandarini mandarini was automatically assigned from nrwl/nx-react-reviewers

1 more reviewer

@Coly010 Coly010 Coly010 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiongemi @yonitou @hassankhan @bennnjamin @Coly010