fix(core): lower socket path by 10 chars to reduce chances of too-long paths#28920
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 76e2b49. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
4 tasks
AgentEnder
approved these changes
Nov 13, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 13, 2024
…g paths (#28920) ## Current Behavior Socket paths have quite a short allowed length. It's easy to hit the maximum. ## Expected Behavior We should exceed the maximum as rarely as possible. By lowering the workspacePath hash portion, we reduce the chances of exceeding the path. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #27725 (cherry picked from commit be8029d)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Socket paths have quite a short allowed length. It's easy to hit the maximum.
Expected Behavior
We should exceed the maximum as rarely as possible. By lowering the workspacePath hash portion, we reduce the chances of exceeding the path.
Related Issue(s)
Fixes #27725