Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 189648c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
JamesHenry
commented
May 22, 2024
| create(context) { | ||
| // jsonc-eslint-parser adds this property to parserServices where appropriate | ||
| if (!(context.parserServices as any).isJSON) { | ||
| if (!(context.sourceCode.parserServices as any).isJSON) { |
Collaborator
Author
There was a problem hiding this comment.
We don't need to wrap this here, it is not a shared rule, so we just migrate the usage
JamesHenry
requested review from
a team,
AgentEnder,
FrozenPandaz,
jaysoo and
vsavkin
as code owners
FrozenPandaz
approved these changes
May 22, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 22, 2024
(cherry picked from commit 8cfc0a0)
4 tasks
7 tasks
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
The built in Nx rules work with ESLint v8 and v9, the crystal plugin works with eslintrc and flat config on both ESLint v8 and v9.
Related Issue(s)
Fixes #22769