Skip to content

fix(testing): deprecate cypress tsconfig option#17165

Merged
barbados-clemens merged 1 commit into
nrwl:masterfrom
barbados-clemens:fix/cy-deprecate-tsconfig-opt
Jun 21, 2023
Merged

fix(testing): deprecate cypress tsconfig option#17165
barbados-clemens merged 1 commit into
nrwl:masterfrom
barbados-clemens:fix/cy-deprecate-tsconfig-opt

Conversation

@barbados-clemens
Copy link
Copy Markdown
Contributor

@barbados-clemens barbados-clemens commented May 23, 2023

Current Behavior

the tsconfig option for the cypress executor does not influence cypress ts compilation and so should be removed

Expected Behavior

no tsconfig option

Related Issue(s)

TODO:

  • migrate any existing custom tsconfig to the root tsconfig.json

Fixes #16963

@barbados-clemens barbados-clemens self-assigned this May 23, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 2:38pm

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label May 23, 2023
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 124e864. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from bb53370 to 60cfcc2 Compare May 24, 2023 16:11
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from 60cfcc2 to ac3cee1 Compare May 24, 2023 16:49
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from ac3cee1 to 3ab314c Compare May 24, 2023 18:57
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from 3ab314c to f526a67 Compare May 31, 2023 19:32
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from f526a67 to 3ddb93b Compare June 1, 2023 14:39
@barbados-clemens barbados-clemens marked this pull request as ready for review June 1, 2023 14:52
@barbados-clemens barbados-clemens requested review from a team as code owners June 1, 2023 14:52
@barbados-clemens barbados-clemens enabled auto-merge (squash) June 1, 2023 19:34
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from 3ddb93b to 382782c Compare June 5, 2023 19:59
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from 382782c to cec80bd Compare June 12, 2023 13:45
Comment thread packages/cypress/src/migrations/update-16-3-0/tsconfig-sourcemaps.ts Outdated
Comment thread packages/cypress/src/migrations/update-16-3-0/tsconfig-sourcemaps.ts Outdated
Comment thread packages/cypress/src/migrations/update-16-3-0/tsconfig-sourcemaps.ts Outdated
@barbados-clemens barbados-clemens force-pushed the fix/cy-deprecate-tsconfig-opt branch from fbfd4e3 to 124e864 Compare June 21, 2023 14:34
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cypress] TS5053: Option 'sourceMap' cannot be specified with option 'inlineSourceMap'.

2 participants