fix(core): remove shellapi from winapi featureset to minimize AV false positives (#34208)

AgentEnder · nx-cloud[bot] · web-flow · commit ece9b5bf4a6a · 2026-02-12T19:32:58.000-05:00
## Current Behavior There's a chance that windows can falsely flag our native binaries as a threat. We do not use the shellapi feature from winapi. ## Expected Behavior We hope that removing this API doesn't break things, and the threat messaging goes away ## Related Issue(s)  Fixes ##34186 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/packages/nx/Cargo.toml b/packages/nx/Cargo.toml
@@ -71,7 +71,10 @@ static_assertions = "1.1"
 wrap-ansi = "0.1"
 
 [target.'cfg(windows)'.dependencies]
-winapi = { version = "0.3", features = ["fileapi", "psapi", "shellapi"] }
+winapi = { version = "0.3", features = ["fileapi", "psapi"] }
+
+[target.'cfg(windows)'.build-dependencies]
+winres = "0.1"
 
 [target.'cfg(all(not(windows), not(target_family = "wasm")))'.dependencies]
 mio = "1.0"
diff --git a/packages/nx/build.rs b/packages/nx/build.rs
@@ -2,4 +2,26 @@ extern crate napi_build;
 
 fn main() {
     napi_build::setup();
+
+    // Embed Windows resource metadata to establish binary legitimacy
+    // and reduce false positive detections from security software
+    #[cfg(windows)]
+    {
+        let mut res = winres::WindowsResource::new();
+        res.set("ProductName", "Nx")
+            .set(
+                "FileDescription",
+                "Nx Native Module - High-performance build system operations",
+            )
+            .set("CompanyName", "Nx")
+            .set("LegalCopyright", "Copyright (c) Nrwl. MIT License.")
+            .set("OriginalFilename", "nx.node")
+            .set("InternalName", "nx");
+
+        if let Err(e) = res.compile() {
+            // Don't fail the build if resource compilation fails
+            // (e.g., when cross-compiling from non-Windows)
+            eprintln!("cargo:warning=Failed to compile Windows resources: {}", e);
+        }
+    }
 }
