fix(angular): ensure jest and jest-preset-angular are updated correctly for angular v21 (#33896)

leosvelperez · web-flow · commit c29834c0a760 · 2025-12-17T08:48:34.000-05:00
## Current Behavior

There's a deadlock between the Angular and Jest package updates
requirements (`requires` and `incompatibleWith`) that prevents updating
Jest to v30 and `jest-preset-angular` to v16.

## Expected Behavior

Updating to Angular v21 should result in updating Jest to v30 and
`jest-preset-angular` to v16.

This is ensured by moving the `jest-preset-angular` package update
definition to the `@nx/jest` package and processing the `@nx/angular`
package updates before `@nx/jest`. That way, by the time `@nx/jest` is
processed, the migrator would have collected the Angular v21 updates,
and the requirements will be met.
diff --git a/packages/angular/migrations.json b/packages/angular/migrations.json
@@ -2160,22 +2160,6 @@
           "alwaysAddToPackageJson": false
         }
       }
-    },
-    "22.3.0-jest": {
-      "version": "22.3.0-beta.0",
-      "requires": {
-        "@angular/compiler-cli": ">=19.0.0 <22.0.0",
-        "@angular/core": ">=19.0.0 <22.0.0",
-        "@angular/platform-browser": ">=19.0.0 <22.0.0",
-        "@angular/platform-browser-dynamic": ">=19.0.0 <22.0.0",
-        "jest": "^30.0.0"
-      },
-      "packages": {
-        "jest-preset-angular": {
-          "version": "~16.0.0",
-          "alwaysAddToPackageJson": false
-        }
-      }
     }
   }
 }
diff --git a/packages/jest/migrations.json b/packages/jest/migrations.json
@@ -101,7 +101,7 @@
       }
     },
     "22.3.0": {
-      "version": "22.3.0-beta.0",
+      "version": "22.3.0-beta.3",
       "x-prompt": "Do you want to update the Jest version to v30?",
       "incompatibleWith": {
         "@angular-devkit/build-angular": "< 21.0.0"
@@ -147,6 +147,22 @@
           "alwaysAddToPackageJson": false
         }
       }
+    },
+    "22.3.0-jest-preset-angular": {
+      "version": "22.3.0-beta.3",
+      "requires": {
+        "@angular/compiler-cli": ">=19.0.0 <22.0.0",
+        "@angular/core": ">=19.0.0 <22.0.0",
+        "@angular/platform-browser": ">=19.0.0 <22.0.0",
+        "@angular/platform-browser-dynamic": ">=19.0.0 <22.0.0",
+        "jest": "^30.0.0"
+      },
+      "packages": {
+        "jest-preset-angular": {
+          "version": "~16.0.0",
+          "alwaysAddToPackageJson": false
+        }
+      }
     }
   }
 }
diff --git a/packages/nx/package.json b/packages/nx/package.json
@@ -101,11 +101,11 @@
     "migrations": "./migrations.json",
     "packageGroup": [
       "@nx/js",
-      "@nx/jest",
       "@nx/linter",
       "@nx/eslint",
       "@nx/workspace",
       "@nx/angular",
+      "@nx/jest",
       "@nx/cypress",
       "@nx/detox",
       "@nx/devkit",

Original file line number	Diff line number	Diff line change
`@@ -2160,22 +2160,6 @@`
`2160`	`2160`	`"alwaysAddToPackageJson": false`
`2161`	`2161`	`}`
`2162`	`2162`	`}`
`2163`		`- },`
`2164`		`- "22.3.0-jest": {`
`2165`		`- "version": "22.3.0-beta.0",`
`2166`		`- "requires": {`
`2167`		`- "@angular/compiler-cli": ">=19.0.0 <22.0.0",`
`2168`		`- "@angular/core": ">=19.0.0 <22.0.0",`
`2169`		`- "@angular/platform-browser": ">=19.0.0 <22.0.0",`
`2170`		`- "@angular/platform-browser-dynamic": ">=19.0.0 <22.0.0",`
`2171`		`- "jest": "^30.0.0"`
`2172`		`- },`
`2173`		`- "packages": {`
`2174`		`- "jest-preset-angular": {`
`2175`		`- "version": "~16.0.0",`
`2176`		`- "alwaysAddToPackageJson": false`
`2177`		`- }`
`2178`		`- }`
`2179`	`2163`	`}`
`2180`	`2164`	`}`
`2181`	`2165`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@`
`101`	`101`	`}`
`102`	`102`	`},`
`103`	`103`	`"22.3.0": {`
`104`		`- "version": "22.3.0-beta.0",`
	`104`	`+ "version": "22.3.0-beta.3",`
`105`	`105`	`"x-prompt": "Do you want to update the Jest version to v30?",`
`106`	`106`	`"incompatibleWith": {`
`107`	`107`	`"@angular-devkit/build-angular": "< 21.0.0"`
`@@ -147,6 +147,22 @@`
`147`	`147`	`"alwaysAddToPackageJson": false`
`148`	`148`	`}`
`149`	`149`	`}`
	`150`	`+ },`
	`151`	`+ "22.3.0-jest-preset-angular": {`
	`152`	`+ "version": "22.3.0-beta.3",`
	`153`	`+ "requires": {`
	`154`	`+ "@angular/compiler-cli": ">=19.0.0 <22.0.0",`
	`155`	`+ "@angular/core": ">=19.0.0 <22.0.0",`
	`156`	`+ "@angular/platform-browser": ">=19.0.0 <22.0.0",`
	`157`	`+ "@angular/platform-browser-dynamic": ">=19.0.0 <22.0.0",`
	`158`	`+ "jest": "^30.0.0"`
	`159`	`+ },`
	`160`	`+ "packages": {`
	`161`	`+ "jest-preset-angular": {`
	`162`	`+ "version": "~16.0.0",`
	`163`	`+ "alwaysAddToPackageJson": false`
	`164`	`+ }`
	`165`	`+ }`
`150`	`166`	`}`
`151`	`167`	`}`
`152`	`168`	`}`