fix(core): use scoped cache key for unresolved npm imports in TargetProjectLocator (#34605)

leosvelperez · FrozenPandaz · commit c16dacda0da4 · 2026-02-26T16:35:13.000-05:00
## Current Behavior `TargetProjectLocator.findProjectFromImport` stores `null` for unresolved imports using a bare `importExpr` key, but `findNpmProjectFromImport` looks up cache entries using `${packageName}__${dirPath}`. The key mismatch means repeated lookups for the same import+directory re-run the full resolution waterfall (typescript + require.resolve) instead of returning the cached `null`. ## Expected Behavior Store `null` for unresolved imports using the same `${packageName}__${dirPath}` key that `findNpmProjectFromImport` uses for lookups. Repeated lookups for already-failed imports skip the expensive resolution steps. Also removes an unused cache write for builtin module imports as a minor cleanup. (cherry picked from commit 098a830)
diff --git a/packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts b/packages/nx/src/plugins/js/project-graph/build-dependencies/target-project-locator.ts
@@ -138,7 +138,6 @@ export class TargetProjectLocator {
     }
 
     if (isBuiltinModuleImport(importExpr)) {
-      this.npmResolutionCache.set(importExpr, null);
       return null;
     }
 
@@ -176,8 +175,14 @@ export class TargetProjectLocator {
       return localProject;
     }
 
-    // nothing found, cache for later
-    this.npmResolutionCache.set(importExpr, null);
+    // nothing found, cache the negative result with the scoped key
+    const packageName = getPackageNameFromImportPath(importExpr);
+    const dirPath = dirname(
+      filePath.startsWith(workspaceRoot)
+        ? filePath.replace(workspaceRoot, '')
+        : filePath
+    );
+    this.npmResolutionCache.set(`${packageName}__${dirPath}`, null);
     return null;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,6 @@ export class TargetProjectLocator {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if (isBuiltinModuleImport(importExpr)) {`
`141`		`- this.npmResolutionCache.set(importExpr, null);`
`142`	`141`	`return null;`
`143`	`142`	`}`
`144`	`143`
`@@ -176,8 +175,14 @@ export class TargetProjectLocator {`
`176`	`175`	`return localProject;`
`177`	`176`	`}`
`178`	`177`
`179`		`- // nothing found, cache for later`
`180`		`- this.npmResolutionCache.set(importExpr, null);`
	`178`	`+ // nothing found, cache the negative result with the scoped key`
	`179`	`+ const packageName = getPackageNameFromImportPath(importExpr);`
	`180`	`+ const dirPath = dirname(`
	`181`	`+ filePath.startsWith(workspaceRoot)`
	`182`	`+ ? filePath.replace(workspaceRoot, '')`
	`183`	`+ : filePath`
	`184`	`+ );`
	`185`	+ this.npmResolutionCache.set(`${packageName}__${dirPath}`, null);
`181`	`186`	`return null;`
`182`	`187`	`}`
`183`	`188`