fix(core): stop adding outdated vscode/cursor rule files to gitignore (#33680)

MaxKless · web-flow · commit adc6d0757e3a · 2025-12-02T11:18:46.000-05:00
## Current Behavior  ## Expected Behavior  ## Related Issue(s)  Fixes #  --- > [!NOTE] > Removes legacy additions of `.cursor/rules/nx-rules.mdc` and `.github/instructions/nx.instructions.md` to `.gitignore` across code, templates, and migrations. > > - **.gitignore behavior**: > - Remove logic in `packages/nx/src/command-line/init/implementation/utils.ts` that appended `.cursor/rules/nx-rules.mdc` and `.github/instructions/nx.instructions.md`. > - Clean up root `.gitignore` to exclude those entries. > - Update new workspace templates (`packages/workspace/.../__dot__gitignore`) to omit those entries. > - **Migrations**: > - Remove migration `21-1-0-add-ignore-entries-for-nx-rule-files` from `packages/nx/migrations.json` and delete its implementation and spec. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7863fa5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>
diff --git a/.gitignore b/.gitignore
@@ -76,9 +76,7 @@ storybook-static
 
 .claude/settings.local.json
 
-.cursor/rules/nx-rules.mdc
 .cursor/mcp.json
-.github/instructions/nx.instructions.md
 
 # Added by Claude Task Master
 # Logs
diff --git a/packages/nx/migrations.json b/packages/nx/migrations.json
@@ -121,11 +121,6 @@
       "description": "Updates release changelog config based on the breaking changes in Nx v21",
       "implementation": "./src/migrations/update-21-0-0/release-changelog-config-changes"
     },
-    "21-1-0-add-ignore-entries-for-nx-rule-files": {
-      "version": "21.1.0-beta.2",
-      "description": "Adds **/nx-rules.mdc and **/nx.instructions.md to .gitignore if not present",
-      "implementation": "./src/migrations/update-21-1-0/add-gitignore-entry"
-    },
     "22-0-0-release-version-config-changes": {
       "version": "22.0.0-beta.1",
       "description": "Updates release version config based on the breaking changes in Nx v22",
diff --git a/packages/nx/src/command-line/init/implementation/utils.ts b/packages/nx/src/command-line/init/implementation/utils.ts
@@ -221,20 +221,6 @@ export function updateGitIgnore(root: string) {
       }
       lines.push('.nx/workspace-data');
     }
-    if (!contents.includes('.cursor/rules/nx-rules.mdc')) {
-      if (!sepIncluded) {
-        lines.push('\n');
-        sepIncluded = true;
-      }
-      lines.push('.cursor/rules/nx-rules.mdc');
-    }
-    if (!contents.includes('.github/instructions/nx.instructions.md')) {
-      if (!sepIncluded) {
-        lines.push('\n');
-        sepIncluded = true;
-      }
-      lines.push('.github/instructions/nx.instructions.md');
-    }
 
     writeFileSync(ignorePath, lines.join('\n'), 'utf-8');
   } catch {}
diff --git a/packages/nx/src/migrations/update-21-1-0/add-gitignore-entry.spec.ts b/packages/nx/src/migrations/update-21-1-0/add-gitignore-entry.spec.ts
diff --git a/packages/nx/src/migrations/update-21-1-0/add-gitignore-entry.ts b/packages/nx/src/migrations/update-21-1-0/add-gitignore-entry.ts
diff --git a/packages/workspace/src/generators/new/files-integrated-repo/__dot__gitignore b/packages/workspace/src/generators/new/files-integrated-repo/__dot__gitignore
@@ -40,5 +40,3 @@ Thumbs.db
 
 .nx/cache
 .nx/workspace-data
-.cursor/rules/nx-rules.mdc
-.github/instructions/nx.instructions.md
diff --git a/packages/workspace/src/generators/new/files-package-based-repo/__dot__gitignore b/packages/workspace/src/generators/new/files-package-based-repo/__dot__gitignore
@@ -40,5 +40,3 @@ Thumbs.db
 
 .nx/cache
 .nx/workspace-data
-.cursor/rules/nx-rules.mdc
-.github/instructions/nx.instructions.md
diff --git a/packages/workspace/src/generators/new/files-root-app/__dot__gitignore b/packages/workspace/src/generators/new/files-root-app/__dot__gitignore
@@ -40,5 +40,3 @@ Thumbs.db
 
 .nx/cache
 .nx/workspace-data
-.cursor/rules/nx-rules.mdc
-.github/instructions/nx.instructions.md
