chore(core): bump Rust toolchain to 1.94.0 and fix all warnings (#35021)

FrozenPandaz · nx-cloud[bot] · FrozenPandaz · commit 5d8615a4f564 · 2026-03-26T18:50:51.000-04:00
## Current Behavior Rust toolchain is pinned to 1.90.0 (4 versions behind stable). Building the native code produces 23 compiler warnings (elided lifetimes, unused imports, dead code). ## Expected Behavior Rust toolchain is updated to 1.94.0 (latest stable). Native code compiles with zero warnings. ## Related Issue(s) N/A — maintenance/hygiene change. ### Changes - **`rust-toolchain.toml`**: 1.90.0 → 1.94.0 - **Glob parser**: Fixed 19 elided lifetime warnings via `cargo fix` - **`task_hasher.rs`**: Removed unused `anyhow::anyhow` import - **`command.rs`**: Removed unnecessary `mut` - **`hash_plan_inspector.rs`**: Removed unused `project_graph` field and constructor parameter - **`hash-plan-inspector.ts`**: Updated TS caller to match new native constructor signature - **`index.d.ts`**: Updated generated types to reflect removed parameter --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> (cherry picked from commit cf82d78)
diff --git a/package.json b/package.json
@@ -23,7 +23,7 @@
     "preinstall": "node ./scripts/preinstall.js",
     "test": "nx run-many -t test",
     "e2e": "nx run-many -t e2e --projects ./e2e/*",
-    "build:wasm": "RUSTUP_TOOLCHAIN=nightly-2025-05-09 rustup target add wasm32-wasip1-threads && RUSTUP_TOOLCHAIN=nightly-2025-05-09 WASI_SDK_PATH=\"$(pwd)/wasi-sdk-23.0-x86_64-linux\" CMAKE_BUILD_PARALLEL_LEVEL=2 LIBSQLITE3_FLAGS=\"-DLONGDOUBLE_TYPE=double\" pnpm exec nx run-many -t build-native-wasm",
+    "build:wasm": "RUSTUP_TOOLCHAIN=nightly-2026-03-01 rustup target add wasm32-wasip1-threads && RUSTUP_TOOLCHAIN=nightly-2026-03-01 WASI_SDK_PATH=\"$(pwd)/wasi-sdk-23.0-x86_64-linux\" CMAKE_BUILD_PARALLEL_LEVEL=2 LIBSQLITE3_FLAGS=\"-DLONGDOUBLE_TYPE=double\" pnpm exec nx run-many -t build-native-wasm",
     "lint-pnpm-lock": "eslint pnpm-lock.yaml",
     "migrate-to-pnpm-version": "node ./scripts/migrate-to-pnpm-version.js",
     "analyze-docs": "node tools/scripts/analyze-docs.mjs",
diff --git a/packages/nx/src/hasher/hash-plan-inspector.ts b/packages/nx/src/hasher/hash-plan-inspector.ts
@@ -49,7 +49,6 @@ export class HashPlanInspector {
     );
     this.inspector = new NativeHashPlanInspector(
       externalReferences.allWorkspaceFiles,
-      this.projectGraphRef,
       externalReferences.projectFiles,
       this.workspaceRootPath
     );
diff --git a/packages/nx/src/native/db/connection.rs b/packages/nx/src/native/db/connection.rs
@@ -77,7 +77,7 @@ impl NxDbConnection {
         }
     }
 
-    pub fn prepare(&self, sql: &str) -> Result<Statement> {
+    pub fn prepare(&self, sql: &str) -> Result<Statement<'_>> {
         if let Some(conn) = &self.conn {
             retry_db_operation_when_busy!(conn.prepare(sql))
                 .map_err(|e| anyhow::anyhow!("DB prepare error: \"{}\", {:?}", sql, e))
diff --git a/packages/nx/src/native/glob.rs b/packages/nx/src/native/glob.rs
@@ -84,7 +84,7 @@ impl NxGlobSet {
 
 fn potential_glob_split(
     glob: &str,
-) -> itertools::Either<std::str::Split<char>, std::iter::Once<&str>> {
+) -> itertools::Either<std::str::Split<'_, char>, std::iter::Once<&str>> {
     use itertools::Either::*;
     if glob.starts_with('{') && glob.ends_with('}') {
         Left(glob.trim_matches('{').trim_end_matches('}').split(','))
diff --git a/packages/nx/src/native/glob/glob_parser.rs b/packages/nx/src/native/glob/glob_parser.rs
@@ -26,72 +26,72 @@ fn special_char_with_no_group(input: &str) -> IResult<&str, &str, VerboseError<&
     })(input)
 }
 
-fn simple_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn simple_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "simple_group",
         map(preceded(tag("("), group), GlobGroup::NonSpecialGroup),
     )(input)
 }
 
-fn zero_or_more_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn zero_or_more_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "zero_or_more_group",
         map(preceded(tag("*("), group), GlobGroup::ZeroOrMore),
     )(input)
 }
 
-fn zero_or_one_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn zero_or_one_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "zero_or_one_group",
         map(preceded(tag("?("), group), GlobGroup::ZeroOrOne),
     )(input)
 }
 
-fn one_or_more_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn one_or_more_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "one_or_more_group",
         map(preceded(tag("+("), group), GlobGroup::OneOrMore),
     )(input)
 }
 
-fn brace_group_with_empty_item(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn brace_group_with_empty_item(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "brace_group_with_empty_item",
         map(preceded(tag("{,"), brace_group), GlobGroup::ZeroOrOne),
     )(input)
 }
 
-fn exact_one_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn exact_one_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "exact_one_group",
         map(preceded(tag("@("), group), GlobGroup::ExactOne),
     )(input)
 }
 
-fn negated_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn negated_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "negated_group",
         map(preceded(tag("!("), group), GlobGroup::Negated),
     )(input)
 }
 
-fn negated_file_group(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn negated_file_group(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context("negated_file_group", |input| {
         let (input, result) = preceded(tag("!("), group)(input)?;
         let (input, _) = tag(".")(input)?;
         Ok((input, GlobGroup::NegatedFileName(result)))
     })(input)
 }
 
-fn negated_wildcard(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn negated_wildcard(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context("negated_wildcard", |input| {
         let (input, result) = preceded(tag("!("), group)(input)?;
         let (input, _) = tag("*")(input)?;
         Ok((input, GlobGroup::NegatedWildcard(result)))
     })(input)
 }
 
-fn non_special_character(input: &str) -> IResult<&str, GlobGroup, VerboseError<&str>> {
+fn non_special_character(input: &str) -> IResult<&str, GlobGroup<'_>, VerboseError<&str>> {
     context(
         "non_special_character",
         map(
@@ -105,21 +105,21 @@ fn non_special_character(input: &str) -> IResult<&str, GlobGroup, VerboseError<&
     )(input)
 }
 
-fn group(input: &str) -> IResult<&str, Cow<str>, VerboseError<&str>> {
+fn group(input: &str) -> IResult<&str, Cow<'_, str>, VerboseError<&str>> {
     context(
         "group",
         map_parser(terminated(take_until(")"), tag(")")), separated_group_items),
     )(input)
 }
 
-fn brace_group(input: &str) -> IResult<&str, Cow<str>, VerboseError<&str>> {
+fn brace_group(input: &str) -> IResult<&str, Cow<'_, str>, VerboseError<&str>> {
     context(
         "brace_group",
         map_parser(terminated(take_until("}"), tag("}")), separated_group_items),
     )(input)
 }
 
-fn separated_group_items(input: &str) -> IResult<&str, Cow<str>, VerboseError<&str>> {
+fn separated_group_items(input: &str) -> IResult<&str, Cow<'_, str>, VerboseError<&str>> {
     map(
         separated_list0(
             alt((tag("|"), tag(","))),
@@ -135,7 +135,7 @@ fn separated_group_items(input: &str) -> IResult<&str, Cow<str>, VerboseError<&s
     )(input)
 }
 
-fn parse_segment(input: &str) -> IResult<&str, Vec<GlobGroup>, VerboseError<&str>> {
+fn parse_segment(input: &str) -> IResult<&str, Vec<GlobGroup<'_>>, VerboseError<&str>> {
     context(
         "parse_segment",
         many_till(
@@ -166,7 +166,7 @@ fn parse_segment(input: &str) -> IResult<&str, Vec<GlobGroup>, VerboseError<&str
     .map(|(i, (groups, _))| (i, groups))
 }
 
-fn separated_segments(input: &str) -> IResult<&str, Vec<Vec<GlobGroup>>, VerboseError<&str>> {
+fn separated_segments(input: &str) -> IResult<&str, Vec<Vec<GlobGroup<'_>>>, VerboseError<&str>> {
     separated_list0(tag("/"), map_parser(take_till(|c| c == '/'), parse_segment))(input)
 }
 
@@ -183,7 +183,7 @@ fn negated_glob(input: &str) -> (&str, bool) {
     }
 }
 
-pub fn parse_glob(input: &str) -> anyhow::Result<(bool, Vec<Vec<GlobGroup>>)> {
+pub fn parse_glob(input: &str) -> anyhow::Result<(bool, Vec<Vec<GlobGroup<'_>>>)> {
     let (input, negated) = negated_glob(input);
     let result = separated_segments(input).finish();
     if let Ok((_, result)) = result {
diff --git a/packages/nx/src/native/index.d.ts b/packages/nx/src/native/index.d.ts
@@ -48,7 +48,7 @@ export declare class FileLock {
 }
 
 export declare class HashPlanInspector {
-  constructor(allWorkspaceFiles: ExternalObject<Array<FileData>>, projectGraph: ExternalObject<ProjectGraph>, projectFileMap: ExternalObject<Record<string, Array<FileData>>>, workspaceRoot: string)
+  constructor(allWorkspaceFiles: ExternalObject<Array<FileData>>, projectFileMap: ExternalObject<Record<string, Array<FileData>>>, workspaceRoot: string)
   /** @deprecated Use `inspectInputs()` instead for structured output. */
   inspect(hashPlans: ExternalObject<Record<string, Array<HashInstruction>>>): Record<string, string[]>
   /**
diff --git a/packages/nx/src/native/machine_id/mod.rs b/packages/nx/src/native/machine_id/mod.rs
@@ -1,3 +1,4 @@
+#[cfg_attr(target_arch = "wasm32", allow(dead_code))]
 pub fn get_machine_id() -> String {
     #[cfg(not(target_arch = "wasm32"))]
     return machine_uid::get().unwrap_or(String::from("machine"));
diff --git a/packages/nx/src/native/tasks/hash_plan_inspector.rs b/packages/nx/src/native/tasks/hash_plan_inspector.rs
@@ -1,4 +1,3 @@
-use crate::native::project_graph::types::ProjectGraph;
 use crate::native::tasks::hashers::{
     hash_project_files_with_inputs, hash_workspace_files_with_inputs, resolve_task_output_files,
 };
@@ -14,7 +13,6 @@ use std::sync::Arc;
 #[napi]
 pub struct HashPlanInspector {
     all_workspace_files: Arc<Vec<FileData>>,
-    project_graph: Arc<ProjectGraph>,
     project_file_map: Arc<HashMap<String, Vec<FileData>>>,
     workspace_root: String,
 }
@@ -26,16 +24,12 @@ impl HashPlanInspector {
         #[napi(ts_arg_type = "ExternalObject<Array<FileData>>")] all_workspace_files: &External<
             Arc<Vec<FileData>>,
         >,
-        #[napi(ts_arg_type = "ExternalObject<ProjectGraph>")] project_graph: &External<
-            Arc<ProjectGraph>,
-        >,
         #[napi(ts_arg_type = "ExternalObject<Record<string, Array<FileData>>>")]
         project_file_map: &External<Arc<HashMap<String, Vec<FileData>>>>,
         workspace_root: String,
     ) -> Self {
         Self {
             all_workspace_files: Arc::clone(all_workspace_files),
-            project_graph: Arc::clone(project_graph),
             project_file_map: Arc::clone(project_file_map),
             workspace_root,
         }
diff --git a/packages/nx/src/native/tasks/task_hasher.rs b/packages/nx/src/native/tasks/task_hasher.rs
@@ -23,7 +23,6 @@ use crate::native::{
     types::FileData,
     workspace::types::ProjectFiles,
 };
-use anyhow::anyhow;
 use dashmap::DashMap;
 use napi::bindgen_prelude::*;
 use rayon::prelude::*;
diff --git a/packages/nx/src/native/tui/components/tasks_list.rs b/packages/nx/src/native/tui/components/tasks_list.rs
@@ -2359,7 +2359,7 @@ impl TasksList {
         column_visibility: &ColumnVisibility,
         selected_style: Style,
         normal_style: Style,
-    ) -> Row {
+    ) -> Row<'_> {
         let status_cell = {
             let mut spans = Self::render_status_prefix(is_selected, is_in_parallel_section);
 
@@ -2420,7 +2420,7 @@ impl TasksList {
         column_visibility: &ColumnVisibility,
         selected_style: Style,
         normal_style: Style,
-    ) -> Row {
+    ) -> Row<'_> {
         let status_cell =
             self.render_task_status_cell(task, is_selected, show_vertical_line, trailing_spaces);
         let name = self.render_name_cell(task_name.clone(), &task_name, indent_name);
diff --git a/packages/nx/src/native/utils/command.rs b/packages/nx/src/native/utils/command.rs
@@ -11,7 +11,7 @@ const CREATE_NO_WINDOW: u32 = 0x08000000;
 /// Use this instead of `Command::new()` directly to avoid spawning visible
 /// console windows from background/daemon processes.
 pub fn create_command(program: &str) -> Command {
-    let mut cmd = Command::new(program);
+    let cmd = Command::new(program);
     #[cfg(target_os = "windows")]
     cmd.creation_flags(CREATE_NO_WINDOW);
     cmd
diff --git a/packages/nx/src/native/utils/file_lock.rs b/packages/nx/src/native/utils/file_lock.rs
@@ -1,3 +1,4 @@
+#[cfg(not(target_arch = "wasm32"))]
 use napi::bindgen_prelude::*;
 use std::fs;
 #[cfg(not(target_arch = "wasm32"))]
@@ -9,6 +10,7 @@ use tracing::trace;
 use fs4::fs_std::FileExt;
 
 #[napi]
+#[cfg_attr(target_arch = "wasm32", allow(dead_code))]
 pub struct FileLock {
     #[napi]
     pub locked: bool,
@@ -116,7 +118,7 @@ impl FileLock {
 #[cfg(target_arch = "wasm32")]
 impl FileLock {
     #[napi(constructor)]
-    pub fn new(lock_file_path: String) -> anyhow::Result<Self> {
+    pub fn new(_lock_file_path: String) -> anyhow::Result<Self> {
         anyhow::bail!("FileLock is not supported on WASM")
     }
 }
diff --git a/packages/nx/src/native/utils/get_mod_time.rs b/packages/nx/src/native/utils/get_mod_time.rs
@@ -20,6 +20,9 @@ pub fn get_mod_time(metadata: &Metadata) -> i64 {
 
 #[cfg(target_os = "wasi")]
 pub fn get_mod_time(metadata: &Metadata) -> i64 {
-    use std::os::wasi::fs::MetadataExt;
-    metadata.mtim() as i64
+    use std::time::UNIX_EPOCH;
+    metadata
+        .modified()
+        .map(|t| t.duration_since(UNIX_EPOCH).unwrap_or_default().as_secs() as i64)
+        .unwrap_or(0)
 }
diff --git a/rust-toolchain.toml b/rust-toolchain.toml
@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.90.0"
+channel = "1.94.0"
 targets = ["wasm32-wasip1-threads"]
 profile = "default"

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ impl NxDbConnection {`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`
`80`		`- pub fn prepare(&self, sql: &str) -> Result<Statement> {`
	`80`	`+ pub fn prepare(&self, sql: &str) -> Result<Statement<'_>> {`
`81`	`81`	`if let Some(conn) = &self.conn {`
`82`	`82`	`retry_db_operation_when_busy!(conn.prepare(sql))`
`83`	`83`	`.map_err(\|e\| anyhow::anyhow!("DB prepare error: \"{}\", {:?}", sql, e))`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export declare class FileLock {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`export declare class HashPlanInspector {`
`51`		`- constructor(allWorkspaceFiles: ExternalObject<Array<FileData>>, projectGraph: ExternalObject<ProjectGraph>, projectFileMap: ExternalObject<Record<string, Array<FileData>>>, workspaceRoot: string)`
	`51`	`+ constructor(allWorkspaceFiles: ExternalObject<Array<FileData>>, projectFileMap: ExternalObject<Record<string, Array<FileData>>>, workspaceRoot: string)`
`52`	`52`	/** @deprecated Use `inspectInputs()` instead for structured output. */
`53`	`53`	`inspect(hashPlans: ExternalObject<Record<string, Array<HashInstruction>>>): Record<string, string[]>`
`54`	`54`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+#[cfg_attr(target_arch = "wasm32", allow(dead_code))]`
`1`	`2`	`pub fn get_machine_id() -> String {`
`2`	`3`	`#[cfg(not(target_arch = "wasm32"))]`
`3`	`4`	`return machine_uid::get().unwrap_or(String::from("machine"));`