fix(core): move tui to parking lot rwlock to avoid hang (#34187)

AgentEnder · nx-cloud[bot] · web-flow · commit 587659cb03f1 · 2026-01-22T15:49:58.000-05:00
## Current Behavior
There's a hard to reproduce hang that happens occasionally when running
the TUI

## Expected Behavior
We think this should fix it

## Related Issue(s)
&lt;!-- Please link the issue being fixed so it gets closed when this is
merged. --&gt;

Fixes #

---------

Co-authored-by: nx-cloud[bot] &lt;71083854+nx-cloud[bot]@users.noreply.github.com&gt;
diff --git a/packages/nx/src/native/pseudo_terminal/child_process.rs b/packages/nx/src/native/pseudo_terminal/child_process.rs
@@ -9,9 +9,9 @@ use napi::{
         ErrorStrategy::Fatal, ThreadsafeFunction, ThreadsafeFunctionCallMode::NonBlocking,
     },
 };
-use parking_lot::Mutex;
+use parking_lot::{Mutex, RwLock};
 use std::io::Write;
-use std::sync::{Arc, RwLock};
+use std::sync::Arc;
 use tracing::warn;
 use vt100_ctt::Parser;
 
diff --git a/packages/nx/src/native/pseudo_terminal/pseudo_terminal.rs b/packages/nx/src/native/pseudo_terminal/pseudo_terminal.rs
@@ -6,10 +6,9 @@ use crossterm::{
     tty::IsTty,
 };
 use napi::bindgen_prelude::*;
-use parking_lot::Mutex;
+use parking_lot::{Mutex, RwLock};
 use portable_pty::{CommandBuilder, NativePtySystem, PtyPair, PtySize, PtySystem};
 use std::io::stdout;
-use std::sync::RwLock;
 use std::{
     collections::HashMap,
     io::{Read, Write},
@@ -111,14 +110,8 @@ impl PseudoTerminal {
                     trace!("Quiet: {}", quiet);
                     debug!("Read {} bytes", len);
                     if is_within_nx_tui {
-                        if let Ok(mut parser) = parser_clone.write() {
-                            if is_within_nx_tui {
-                                trace!("Processing data via vt100 for use in tui");
-                                parser.process(&buf[..len]);
-                            }
-                        } else {
-                            debug!("Failed to lock parser");
-                        }
+                        trace!("Processing data via vt100 for use in tui");
+                        parser_clone.write().process(&buf[..len]);
                     }
 
                     if !quiet {
@@ -213,10 +206,7 @@ impl PseudoTerminal {
 
         if self.is_within_nx_tui {
             // within the tui, update the parser directly so it is displayed in the tui
-            self.parser
-                .write()
-                .expect("Failed to acquire parser write lock")
-                .process(command_info.as_bytes());
+            self.parser.write().process(command_info.as_bytes());
         } else if !quiet {
             // outside the tui, just print to stdout so the user can see it
             if let Err(e) = std::io::stdout().write_all(command_info.as_bytes()) {
diff --git a/packages/nx/src/native/tui/pty.rs b/packages/nx/src/native/tui/pty.rs
