fix(release): interpolate releaseGroupName in getLatestGitTagForPattern (#33674)

jogelin · JamesHenry · web-flow · commit 4923c15e7e65 · 2025-12-02T10:23:26.000Z
# Fix: Pass releaseGroupName to getLatestGitTagForPattern for proper tag
resolution

## Problem

When using `releaseTag.pattern: "{releaseGroupName}@{version}"`, Nx
fails to resolve versions from git tags because the `{releaseGroupName}`
placeholder is not interpolated.

For example, with git tag `my-group@2.9.0`:
- **Expected**: Extract version `2.9.0`
- **Actual**: Extracts `"my-group"` → Error: `Invalid semver version
'my-group' provided`

## Root Cause

In `release-graph.ts:627-631`, only `projectName` is passed to
`getLatestGitTagForPattern()`, missing `releaseGroupName` needed for
interpolation.

## Solution

Pass `releaseGroupName` to the interpolation data (1-line change at
`release-graph.ts:631`):

```typescript
latestMatchingGitTag = await getLatestGitTagForPattern(
  releaseTagPattern,
  {
    projectName: projectGraphNode.name,
    releaseGroupName: releaseGroupNode.group.name, // ✅ Added
  },
  { ... }
);
```

## Backward Compatibility

✅ Fully backward compatible:
- `releaseGroupNode.group.name` is always defined (user-defined or
`"__default__"`)
- Unused interpolation data is safely ignored
- Existing patterns (`v{version}`, `{projectName}@{version}`) continue
to work

## Tests

Added test case in `git.spec.ts` for `{releaseGroupName}@{version}`
pattern that verifies correct tag matching and version extraction.

## Files Changed

- `packages/nx/src/command-line/release/utils/release-graph.ts` (1 line)
- `packages/nx/src/command-line/release/utils/git.spec.ts` (1 test case)

Co-authored-by: James Henry &lt;james@henry.sc&gt;
diff --git a/packages/nx/src/command-line/release/utils/git.spec.ts b/packages/nx/src/command-line/release/utils/git.spec.ts
@@ -25,6 +25,7 @@ alpha-lib@1.2.4
 alpha-lib@1.2.4-beta.1
 lib-only-pre-release@1.2.4-beta.1
 lib-only-pre-release@1.2.4-beta.1+build.1
+my-group@1.5.0
 `)
   ),
 }));
@@ -288,13 +289,22 @@ See merge request nx-release-test/nx-release-test!2`,
           expectedVersion: '1.2.4-beta.1',
           preid: 'alpha',
         },
+        {
+          pattern: '{releaseGroupName}@{version}',
+          releaseGroupName: 'my-group',
+          projectName: 'my-project',
+          expectedTag: 'my-group@1.5.0',
+          expectedVersion: '1.5.0',
+          requireSemver: true,
+        },
       ];
 
       it.each(releaseTagPatternTestCases)(
         'should return tag $expectedTag for pattern $pattern and preid $preid',
         async ({
           pattern,
           projectName,
+          releaseGroupName,
           expectedTag,
           expectedVersion,
           requireSemver,
@@ -304,6 +314,7 @@ See merge request nx-release-test/nx-release-test!2`,
             pattern,
             {
               projectName,
+              releaseGroupName,
             },
             {
               requireSemver,
diff --git a/packages/nx/src/command-line/release/utils/release-graph.ts b/packages/nx/src/command-line/release/utils/release-graph.ts
@@ -628,6 +628,7 @@ export class ReleaseGraph {
             releaseTagPattern,
             {
               projectName: projectGraphNode.name,
+              releaseGroupName: releaseGroupNode.group.name,
             },
             {
               checkAllBranchesWhen:

Original file line number	Diff line number	Diff line change
`@@ -628,6 +628,7 @@ export class ReleaseGraph {`
`628`	`628`	`releaseTagPattern,`
`629`	`629`	`{`
`630`	`630`	`projectName: projectGraphNode.name,`
	`631`	`+ releaseGroupName: releaseGroupNode.group.name,`
`631`	`632`	`},`
`632`	`633`	`{`
`633`	`634`	`checkAllBranchesWhen:`