Skip to content

Commit 1cb6c0b

Browse files
fix(core): nx should show help for run-one when using project short names (#34303)
## Current Behavior Given a project name like `:foo`, you can run tasks like `nx test foo` (note `foo` vs `:foo`), but passing --help throws an error ## Expected Behavior `--help` works the same with the shortname vs full name ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
1 parent 3f6bdc7 commit 1cb6c0b

1 file changed

Lines changed: 26 additions & 18 deletions

File tree

packages/nx/src/command-line/run/run-one.ts

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
1-
import { runCommand } from '../../tasks-runner/run-command';
1+
import { calculateDefaultProjectName } from '../../config/calculate-default-project-name';
2+
import { readNxJson } from '../../config/configuration';
3+
import { NxJsonConfiguration } from '../../config/nx-json';
24
import {
3-
readGraphFileFromGraphArg,
4-
splitArgsIntoNxArgsAndOverrides,
5-
} from '../../utils/command-line-utils';
6-
import { connectToNxCloudIfExplicitlyAsked } from '../nx-cloud/connect/connect-to-nx-cloud';
5+
ProjectGraph,
6+
ProjectGraphProjectNode,
7+
} from '../../config/project-graph';
8+
import { TargetDependencyConfig } from '../../config/workspace-json-project-json';
79
import {
810
createProjectGraphAsync,
911
readProjectsConfigurationFromProjectGraph,
1012
} from '../../project-graph/project-graph';
13+
import { runCommand } from '../../tasks-runner/run-command';
1114
import {
12-
ProjectGraph,
13-
ProjectGraphProjectNode,
14-
} from '../../config/project-graph';
15-
import { NxJsonConfiguration } from '../../config/nx-json';
16-
import { workspaceRoot } from '../../utils/workspace-root';
17-
import { splitTarget } from '../../utils/split-target';
15+
readGraphFileFromGraphArg,
16+
splitArgsIntoNxArgsAndOverrides,
17+
} from '../../utils/command-line-utils';
18+
import { findMatchingProjects } from '../../utils/find-matching-projects';
1819
import { output } from '../../utils/output';
19-
import { TargetDependencyConfig } from '../../config/workspace-json-project-json';
20-
import { readNxJson } from '../../config/configuration';
21-
import { calculateDefaultProjectName } from '../../config/calculate-default-project-name';
20+
import { splitTarget } from '../../utils/split-target';
21+
import { workspaceRoot } from '../../utils/workspace-root';
2222
import { generateGraph } from '../graph/graph';
23-
import { findMatchingProjects } from '../../utils/find-matching-projects';
23+
import { connectToNxCloudIfExplicitlyAsked } from '../nx-cloud/connect/connect-to-nx-cloud';
2424

2525
export async function runOne(
2626
cwd: string,
@@ -56,15 +56,23 @@ export async function runOne(
5656
nxJson
5757
);
5858

59+
const { projects, projectName } = getProjects(projectGraph, opts.project);
60+
5961
if (nxArgs.help) {
60-
await (await import('./run')).printTargetRunHelp(opts, workspaceRoot);
62+
await (
63+
await import('./run')
64+
).printTargetRunHelp(
65+
{
66+
...opts,
67+
project: projectName,
68+
},
69+
workspaceRoot
70+
);
6171
process.exit(0);
6272
}
6373

6474
await connectToNxCloudIfExplicitlyAsked(nxArgs);
6575

66-
const { projects, projectName } = getProjects(projectGraph, opts.project);
67-
6876
if (nxArgs.graph) {
6977
const projectNames = projects.map((t) => t.name);
7078
const file = readGraphFileFromGraphArg(nxArgs);

0 commit comments

Comments
 (0)