fix(core): cloud commands are noop when not connected rather than errors (#34193)

jaysoo · FrozenPandaz · commit 0e37963f6771 · 2026-01-26T09:58:19.000-05:00
This PR makes it so Cloud commands like `npx nx record` and `npx nx fix-ci` still work without `nxCloudId`. We'll log a warning so that `ci.yml` using these commands will still work. The warning let's users know that these do not work without being connected. Closes #NXC-3753 (cherry picked from commit 687357c)
diff --git a/packages/nx/src/command-line/nx-cloud/complete-run/stop-all-agents.ts b/packages/nx/src/command-line/nx-cloud/complete-run/stop-all-agents.ts
@@ -1,9 +1,15 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface StopAllAgentsArgs {
   verbose?: boolean;
 }
 
 export function stopAllAgentsHandler(args: StopAllAgentsArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
   return executeNxCloudCommand('stop-all-agents', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/fix-ci/fix-ci.ts b/packages/nx/src/command-line/nx-cloud/fix-ci/fix-ci.ts
@@ -1,9 +1,15 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface FixCiArgs {
   verbose?: boolean;
 }
 
 export function fixCiHandler(args: FixCiArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
   return executeNxCloudCommand('fix-ci', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/login/login.ts b/packages/nx/src/command-line/nx-cloud/login/login.ts
@@ -1,11 +1,18 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface LoginArgs {
   nxCloudUrl?: string;
   verbose?: boolean;
 }
 
 export function loginHandler(args: LoginArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
+
   if (args.nxCloudUrl) {
     process.env.NX_CLOUD_API = args.nxCloudUrl;
   }
diff --git a/packages/nx/src/command-line/nx-cloud/logout/logout.ts b/packages/nx/src/command-line/nx-cloud/logout/logout.ts
@@ -1,9 +1,15 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface LogoutArgs {
   verbose?: boolean;
 }
 
 export function logoutHandler(args: LogoutArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
   return executeNxCloudCommand('logout', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/record/command-object.ts b/packages/nx/src/command-line/nx-cloud/record/command-object.ts
@@ -7,6 +7,9 @@ export const yargsRecordCommand: CommandModule = {
     'Records a command execution for distributed task execution. This command is an alias for [`nx-cloud record`](/ci/reference/nx-cloud-cli#npx-nxcloud-record).',
   builder: (yargs) =>
     withVerbose(yargs)
+      .parserConfiguration({
+        'populate--': true,
+      })
       .help(false)
       .showHelpOnFail(false)
       .option('help', { describe: 'Show help.', type: 'boolean' }),
diff --git a/packages/nx/src/command-line/nx-cloud/record/record.ts b/packages/nx/src/command-line/nx-cloud/record/record.ts
@@ -1,9 +1,36 @@
+import { spawnSync } from 'child_process';
+import { readNxJson } from '../../../config/nx-json';
+import { output } from '../../../utils/output';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
 import { executeNxCloudCommand } from '../utils';
 
 export interface RecordArgs {
   verbose?: boolean;
+  '--'?: string[];
 }
 
 export function recordHandler(args: RecordArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    let exitCode: number = 0;
+    const commandArgs = args['--'];
+    if (commandArgs && commandArgs.length > 0) {
+      const [cmd, ...cmdArgs] = commandArgs;
+      const result = spawnSync(cmd, cmdArgs, {
+        stdio: 'inherit',
+        shell: true,
+        encoding: 'utf-8',
+        maxBuffer: 10 * 1024 * 1024, // 10MB buffer
+        windowsHide: true,
+      });
+      exitCode = result.status ?? 1;
+    }
+    output.warn({
+      title: 'Nx Cloud is not enabled',
+      bodyLines: [
+        'To record command using Nx Cloud, connect your workspace with `nx connect`.',
+      ],
+    });
+    return Promise.resolve(exitCode);
+  }
   return executeNxCloudCommand('record', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/start-agent/start-agent.ts b/packages/nx/src/command-line/nx-cloud/start-agent/start-agent.ts
@@ -1,9 +1,15 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface StartAgentArgs {
   verbose?: boolean;
 }
 
 export function startAgentHandler(args: StartAgentArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
   return executeNxCloudCommand('start-agent', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/start-ci-run/start-ci-run.ts b/packages/nx/src/command-line/nx-cloud/start-ci-run/start-ci-run.ts
@@ -1,9 +1,15 @@
-import { executeNxCloudCommand } from '../utils';
+import { readNxJson } from '../../../config/nx-json';
+import { isNxCloudUsed } from '../../../utils/nx-cloud-utils';
+import { executeNxCloudCommand, warnNotConnectedToCloud } from '../utils';
 
 export interface StartCiRunArgs {
   verbose?: boolean;
 }
 
 export function startCiRunHandler(args: StartCiRunArgs): Promise<number> {
+  if (!isNxCloudUsed(readNxJson())) {
+    warnNotConnectedToCloud();
+    return Promise.resolve(0);
+  }
   return executeNxCloudCommand('start-ci-run', args.verbose);
 }
diff --git a/packages/nx/src/command-line/nx-cloud/utils.ts b/packages/nx/src/command-line/nx-cloud/utils.ts
@@ -2,6 +2,17 @@ import { verifyOrUpdateNxCloudClient } from '../../nx-cloud/update-manager';
 import { getCloudOptions } from '../../nx-cloud/utilities/get-cloud-options';
 import { handleErrors } from '../../utils/handle-errors';
 import { findAncestorNodeModules } from '../../nx-cloud/resolution-helpers';
+import { output } from '../../utils/output';
+
+export function warnNotConnectedToCloud(): void {
+  output.warn({
+    title: 'Nx Cloud is not enabled',
+    bodyLines: [
+      'This command requires a connection to the full Nx platform.',
+      'Run `nx connect` to connect your workspace.',
+    ],
+  });
+}
 
 export async function executeNxCloudCommand(
   commandName: string,
diff --git a/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap b/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap
diff --git a/packages/workspace/src/generators/ci-workflow/ci-workflow.spec.ts b/packages/workspace/src/generators/ci-workflow/ci-workflow.spec.ts
diff --git a/packages/workspace/src/generators/ci-workflow/ci-workflow.ts b/packages/workspace/src/generators/ci-workflow/ci-workflow.ts
