fix(core): avoid crash when pane area is out of bounds during resize (#34343)

leosvelperez · web-flow · commit 0cac182b7304 · 2026-02-05T17:11:47.000-05:00
## Current Behavior

In some resize/background scenarios, the TUI could crash while rendering
output panes, displaying a "Scrollbar area is empty" message.

## Expected Behavior

The TUI remains stable during resizes and backgrounding. Output panes no
longer crash when a scrollbar would render in an invalid area.
diff --git a/packages/nx/src/native/tui/components/terminal_pane.rs b/packages/nx/src/native/tui/components/terminal_pane.rs
@@ -419,36 +419,24 @@ impl<'a> StatefulWidget for TerminalPane<'a> {
     type State = TerminalPaneState;
 
     fn render(self, area: Rect, buf: &mut Buffer, state: &mut Self::State) {
+        // Clamp to the buffer to avoid rendering outside bounds
+        let safe_area = area.intersection(*buf.area());
+        if safe_area.width == 0 || safe_area.height == 0 {
+            return;
+        }
+
         // Add bounds checking to prevent panic when terminal is too narrow
         // Safety check: ensure area is at least 5x5 to render anything properly
-        if area.width < 5 || area.height < 5 {
+        if safe_area.width < 5 || safe_area.height < 5 {
             // Just render a minimal indicator instead of a full pane
-            let safe_area = Rect {
-                x: area.x,
-                y: area.y,
-                width: area.width.min(buf.area().width.saturating_sub(area.x)),
-                height: area.height.min(buf.area().height.saturating_sub(area.y)),
-            };
-
-            if safe_area.width > 0 && safe_area.height > 0 {
-                // Only attempt to render if we have a valid area
-                let text = "...";
-                let paragraph = Paragraph::new(text)
-                    .style(Style::default().fg(THEME.secondary_fg))
-                    .alignment(Alignment::Center);
-                Widget::render(paragraph, safe_area, buf);
-            }
+            let text = "...";
+            let paragraph = Paragraph::new(text)
+                .style(Style::default().fg(THEME.secondary_fg))
+                .alignment(Alignment::Center);
+            Widget::render(paragraph, safe_area, buf);
             return;
         }
 
-        // Ensure the area doesn't extend beyond buffer boundaries
-        let safe_area = Rect {
-            x: area.x,
-            y: area.y,
-            width: area.width.min(buf.area().width.saturating_sub(area.x)),
-            height: area.height.min(buf.area().height.saturating_sub(area.y)),
-        };
-
         let base_style = self.get_base_style(state.task_status);
         let border_style = if state.is_focused {
             base_style
