Skip to content

Commit 0bbf0bf

Browse files
mpsanchisFrozenPandaz
mpsanchis
authored and
FrozenPandaz
committed
fix(release): allow null values in schema of dockerVersion (#34171)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> TS file documents `projectVersionData.dockerVersion` as having type `string | undefined`. However, code behaves differently. For instance, [here](https://github.com/nrwl/nx/blob/e57848cea748b85f17e5fc704b901975a8424c4d/packages/nx/src/command-line/release/version/release-group-processor.ts#L128) and [here](https://github.com/nrwl/nx/blob/e57848cea748b85f17e5fc704b901975a8424c4d/packages/nx/src/command-line/release/utils/shared.ts#L294) it is setting as and comparing against `null`. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Schema has value that code sets (`null`) ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #34172 (cherry picked from commit b72a203)
1 parent dab79e5 commit 0bbf0bf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • packages/nx/src/command-line/release/utils

‎packages/nx/src/command-line/release/utils/shared.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export interface VersionDataEntry {
3434
* dockerVersion will be populated if the project is a docker project and has been
3535
* included within this release.
3636
*/
37-
dockerVersion?: string;
37+
dockerVersion?: string | null;
3838
/**
3939
* The list of projects which depend upon the current project.
4040
*/

0 commit comments

Comments
 (0)